Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add token price privacy spec #28556

Merged
merged 1 commit into from
Nov 20, 2024
Merged

test: add token price privacy spec #28556

merged 1 commit into from
Nov 20, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Nov 20, 2024

Description

There was a bug where the token price requests were performed before the onboarding (see here) and was fixed by this PR.

This test adds coverage to this scenario so the issue is not re-introduced again.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3659

Manual testing steps

  1. Run the test before and after the fix was merged: see how it fails before and it passes after

Screenshots/Recordings

Before

before-token-price.mp4

After

after-token-price.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [00173fa]
Page Load Metrics (2314 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36626552063588282
domContentLoaded199729482271255123
load202629542314251121
domInteractive3110348209
backgroundConnect1183462210
firstReactRender622901026129
getState50210983718
initialActions01000
loadScripts15122262172520297
setupStore75214126
uiStartup231433402676298143
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona changed the title test: add token price privacy test: add token price privacy spec Nov 20, 2024
@seaona seaona self-assigned this Nov 20, 2024
@seaona seaona added e2e-test End to end test for the MetaMask extension area-qa Relating to QA work (Quality Assurance) labels Nov 20, 2024
@seaona seaona marked this pull request as ready for review November 20, 2024 09:18
@seaona seaona requested a review from a team as a code owner November 20, 2024 09:18
@sahar-fehri
Copy link
Contributor

LGTM! Thank you for adding the tests 🙏

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@seaona seaona added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 71d01b8 Nov 20, 2024
120 checks passed
@seaona seaona deleted the test-privacy-token-price branch November 20, 2024 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) e2e-test End to end test for the MetaMask extension release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants