-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add token price privacy spec #28556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [00173fa]
Page Load Metrics (2314 ± 121 ms)
Bundle size diffs
|
seaona
changed the title
test: add token price privacy
test: add token price privacy spec
Nov 20, 2024
seaona
added
e2e-test
End to end test for the MetaMask extension
area-qa
Relating to QA work (Quality Assurance)
labels
Nov 20, 2024
sahar-fehri
approved these changes
Nov 20, 2024
LGTM! Thank you for adding the tests 🙏 |
chloeYue
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-qa
Relating to QA work (Quality Assurance)
e2e-test
End to end test for the MetaMask extension
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug where the token price requests were performed before the onboarding (see here) and was fixed by this PR.
This test adds coverage to this scenario so the issue is not re-introduced again.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3659
Manual testing steps
Screenshots/Recordings
Before
before-token-price.mp4
After
after-token-price.mp4
Pre-merge author checklist
Pre-merge reviewer checklist