Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Snaps packages #28557

Merged
merged 4 commits into from
Nov 20, 2024
Merged

chore: Bump Snaps packages #28557

merged 4 commits into from
Nov 20, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 20, 2024

Description

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:

  • Add support for Address in Card title
  • Make fetch responses an instance of Response
  • Add isSecureContext global
  • Use arrayBuffer for fetching local Snaps
  • Add interface persistence (unused for now)

Open in GitHub Codespaces

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Nov 20, 2024
Copy link

socket-security bot commented Nov 20, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [345fbe3]
Page Load Metrics (2026 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63823491953352169
domContentLoaded17102283199516680
load17222334202617986
domInteractive289445199
backgroundConnect9128313014
firstReactRender713781408541
getState792481154120
initialActions01000
loadScripts12321729149214268
setupStore613821
uiStartup203132432452283136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 671 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 1.26 KiB (0.02%)

## **Description**

This PR adds support for the `Address` component in the `Card` title
following this PR: MetaMask/snaps#2894

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28539?quickstart=1)

## **Related issues**

## **Manual testing steps**

```jsx
<Card
  image='foo'
  title={<Address address={your address in MetaMask} displayName avatar={false} />}
  description='bar'
  extra='foobar'
/>
```

## **Screenshots/Recordings**


![241119_12h11m39s_screenshot](https://github.com/user-attachments/assets/9b32d7f6-aef4-415b-800a-350cde6696d8)


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [7545970]
Page Load Metrics (2128 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48427722058403194
domContentLoaded18642602209515976
load18792794212818991
domInteractive296642116
backgroundConnect8191304019
firstReactRender763071236632
getState442881085627
initialActions01000
loadScripts13821922158512560
setupStore78218199
uiStartup222035992520318153
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 671 Bytes (0.01%)
  • ui: 335 Bytes (0.00%)
  • common: 1.26 KiB (0.02%)

@FrederikBolding FrederikBolding marked this pull request as ready for review November 20, 2024 14:48
@FrederikBolding FrederikBolding requested review from a team as code owners November 20, 2024 14:48
@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 220e932 Nov 20, 2024
80 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v78 branch November 20, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants