-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add alert when selected account is different from signing account in confirmation #28562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [94786bc]
Page Load Metrics (1827 ± 105 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
previously approved these changes
Nov 21, 2024
ui/pages/confirmations/components/confirm/info/token-transfer/transaction-flow-section.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/hooks/alerts/useSelectedAccountAlerts.ts
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/hooks/alerts/useSelectedAccountAlerts.ts
Outdated
Show resolved
Hide resolved
Builds ready [417e532]
Page Load Metrics (1900 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ad1b26f]
Page Load Metrics (1813 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Nov 22, 2024
vinistevam
approved these changes
Nov 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 25, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show warning when signing account in confirmation is different from currently selected account in MM.
Related issues
Fixes: #28015
Manual testing steps
Screenshots/Recordings
Signature Request:
Contract Interaction:
Send token:
Pre-merge author checklist
Pre-merge reviewer checklist