Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add alert when selected account is different from signing account in confirmation #28562

Merged
merged 15 commits into from
Nov 25, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 20, 2024

Description

Show warning when signing account in confirmation is different from currently selected account in MM.

Related issues

Fixes: #28015

Manual testing steps

  1. Go to test dapp and connect with an account
  2. Switch to a different account
  3. Submit a confirmation and check warning next to signing account

Screenshots/Recordings

Signature Request:
Screenshot 2024-11-20 at 6 12 02 PM

Contract Interaction:
Screenshot 2024-11-20 at 6 12 16 PM

Send token:
Screenshot 2024-11-20 at 6 47 29 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Nov 20, 2024
@jpuri jpuri requested review from a team as code owners November 20, 2024 12:43
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [94786bc]
Page Load Metrics (1827 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint150323221832212102
domContentLoaded14932245179419594
load150523381827218105
domInteractive147936147
backgroundConnect799343215
firstReactRender55299935627
getState43201893718
initialActions00000
loadScripts10571725134316579
setupStore636963
uiStartup187327322141254122
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.63 KiB (0.05%)
  • common: 229 Bytes (0.00%)

@jpuri jpuri enabled auto-merge November 22, 2024 00:14
@metamaskbot
Copy link
Collaborator

Builds ready [417e532]
Page Load Metrics (1900 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21922201749523251
domContentLoaded16522148185513364
load16732235190015072
domInteractive178546199
backgroundConnect11114502713
firstReactRender683091195225
getState475232110
initialActions00000
loadScripts11601654136212058
setupStore68416209
uiStartup18702578216219493
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.63 KiB (0.05%)
  • common: 229 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ad1b26f]
Page Load Metrics (1813 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16512256182413163
domContentLoaded16062230179013263
load16532259181313565
domInteractive18189413517
backgroundConnect1192282010
firstReactRender53141982512
getState55814168
initialActions01000
loadScripts1161151813188842
setupStore65916199
uiStartup18192521201915474
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 5.94 KiB (0.08%)
  • common: 229 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@jpuri jpuri added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit ebb4926 Nov 25, 2024
75 checks passed
@jpuri jpuri deleted the selected_account_alert branch November 25, 2024 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
4 participants