Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide maximal asset list filter space #28590

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 21, 2024

Description

"All networks" is being ellipsized in the popup view. This maximum length is not useful; removing it makes it still ellipsize well.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open the popup
  2. See "All networks" text fully
  3. Open the console elements panel and set an account name a mile long
  4. See it ellipsize properly

Screenshots/Recordings

Before

After

SCR-20241120-scod

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 21, 2024 02:55
@darkwing darkwing added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 21, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [da8096a]
Page Load Metrics (2029 ± 123 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32925721923442212
domContentLoaded167425541982252121
load169025792029256123
domInteractive2799532110
backgroundConnect1285472311
firstReactRender581831082311
getState76615136
initialActions01000
loadScripts120819361482214103
setupStore6481094
uiStartup191628792238279134
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit c574e23 Nov 22, 2024
83 checks passed
@gambinish gambinish deleted the asset-list-dropdown-ellipsis branch November 22, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants