Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix display amount when price checker off #28612

Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Nov 21, 2024

Description

I eventually did not cherry pick #28569 because it tried to add code related to Portfolio View which is not yet in this version, so i added the fix manually.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to Settings=> Security and privacy and disable price checker setting
  2. Go back to home page and you should see correct balance in crypto

Screenshots/Recordings

Before

Screen.Recording.2024-11-21.at.14.30.48.mov

After

Screen.Recording.2024-11-21.at.14.25.22.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner November 21, 2024 13:26
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

danjm
danjm previously approved these changes Nov 21, 2024
@danjm danjm merged commit 4c3f46c into Version-v12.7.1 Nov 21, 2024
71 of 72 checks passed
@danjm danjm deleted the cherry-pick-coin-overview-display-when-price-checker-off branch November 21, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8b1240e]
Page Load Metrics (2259 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33128042165467224
domContentLoaded19022793221319694
load19532805225920397
domInteractive30179593316
backgroundConnect9142493416
firstReactRender79163111189
getState86519178
initialActions01000
loadScripts14182245165818488
setupStore1372302010
uiStartup215330532495210101

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants