Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run MMI tests on long-running branches #28651

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 22, 2024

Description

The check_mmi_trigger.sh script has been updated to run MMI-related tests on long-running branches (develop, master, and RCs). This is intended to make it easier for us to detect these regressions sooner, so that we don't waste time tracking down the commit that caused any given breakage.
Open in GitHub Codespaces

Related issues

No linked issue. This is intended to make it safer to extend the use of this MMI filter to other jobs, which will help us save CircleCI credits

Manual testing steps

I tested this locally by running the script with the CIRCLE_PULL_REQUEST, GITHUB_TOKEN, and CIRCLE_BRANCH environment variables set. e.g.

> CIRCLE_PULL_REQUEST=foo GITHUB_TOKEN=foo CIRCLE_BRANCH=Version-v12.0.0 ./.circleci/scripts/check_mmi_trigger.sh
Long-running branch detected, running MMI tests.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The `check_mmi_trigger.sh` script has been updated to run MMI-related
tests on long-running branches (`develop`, `master`, and RCs). This is
intended to make it easier for us to detect these regressions sooner,
so that we don't waste time tracking down the commit that caused any
given breakage.
@Gudahtt Gudahtt marked this pull request as ready for review November 22, 2024 14:43
@Gudahtt Gudahtt requested review from kumavis and a team as code owners November 22, 2024 14:43
@Gudahtt Gudahtt mentioned this pull request Nov 22, 2024
7 tasks
@metamaskbot
Copy link
Collaborator

Builds ready [5883dcf]
Page Load Metrics (1990 ± 133 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34927881902451217
domContentLoaded168426781948262126
load171227871990277133
domInteractive22155503617
backgroundConnect9105482612
firstReactRender572841226029
getState46919178
initialActions00000
loadScripts12201991143720498
setupStore665192010
uiStartup189931542245342164
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit 89a06d2 Nov 22, 2024
75 checks passed
@HowardBraham HowardBraham deleted the run-mmi-tests-on-develop branch November 22, 2024 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform team-mmi PRs from the MMI team team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants