Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Restrict MMI test runs #28655

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore: Restrict MMI test runs #28655

merged 2 commits into from
Nov 25, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 22, 2024

Description

The standard MMI e2e test suite now only runs on long-running branches, and for MMI-related changes. This should reduce CircleCI credit usage substantially.

Open in GitHub Codespaces

Related issues

No issue. This is just to reduce credit usage.

Manual testing steps

We should see in the logs for the test-e2e-mmi job on this PR that the tests were skipped.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt

This comment was marked as resolved.

@metamaskbot
Copy link
Collaborator

Builds ready [e493c5c]
Page Load Metrics (1966 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50223071890350168
domContentLoaded16962276192314570
load17532304196614871
domInteractive22135493014
backgroundConnect11130423215
firstReactRender482891255125
getState575342412
initialActions01000
loadScripts11991752141113163
setupStore622932
uiStartup19602607223418891
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

The standard MMI e2e test suite now only runs on long-running branches,
and for MMI-related changes. This should reduce CircleCI credit usage
substantially.
@Gudahtt Gudahtt marked this pull request as ready for review November 22, 2024 18:19
@Gudahtt Gudahtt requested review from kumavis and a team as code owners November 22, 2024 18:19
@metamaskbot
Copy link
Collaborator

Builds ready [3a363b5]
Page Load Metrics (2227 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint169129032240232111
domContentLoaded167828002185224108
load169128172227216104
domInteractive15106462412
backgroundConnect13108473115
firstReactRender813101535225
getState687202110
initialActions00000
loadScripts12351840161014770
setupStore885252612
uiStartup206832092566286137
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as draft November 22, 2024 20:03
@Gudahtt Gudahtt removed the team-mmi PRs from the MMI team label Nov 22, 2024
It was insufficient to use the trigger just to stop the build, because
this trigger still leaves the job status as successful rather than
skipped (so subsequent jobs still run).
@Gudahtt Gudahtt marked this pull request as ready for review November 22, 2024 20:50
@metamaskbot
Copy link
Collaborator

Builds ready [6c07a66]
Page Load Metrics (1893 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint168224391891220106
domContentLoaded16542315184818890
load168425241893232112
domInteractive14200554321
backgroundConnect11277466029
firstReactRender462201143919
getState5188194019
initialActions01000
loadScripts11931835136916981
setupStore579202311
uiStartup184530192120290139
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@Gudahtt Gudahtt added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 6c080b9 Nov 25, 2024
78 checks passed
@Gudahtt Gudahtt deleted the restrict-mmi-e2e-test-runs branch November 25, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants