Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce max pet name length #28660

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: Reduce max pet name length #28660

merged 1 commit into from
Nov 25, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Nov 22, 2024

Description

Following up on #28560, reduce truncation length to 12 characters instead of 15 (see screenshots).

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3630
Related: #28560

Manual testing steps

  1. Trigger a new confirmation
  2. Add a long petname, by clicking an address and writing it in the input field
  3. The name should be truncated with an ellipsis.

Screenshots/Recordings

Before

Max 15 chars

limit 15

After

Max 12 chars

limit 12

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Nov 22, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Nov 22, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner November 22, 2024 17:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title Reduce max pet name length fix: Reduce max pet name length Nov 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [79cd7bc]
Page Load Metrics (1824 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15782319182720498
domContentLoaded15692237178919895
load157723251824211101
domInteractive14181413417
backgroundConnect1085402512
firstReactRender631981133617
getState57817189
initialActions01000
loadScripts11391698131915876
setupStore65514168
uiStartup178525832044231111
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

matthewwalsh0
matthewwalsh0 previously approved these changes Nov 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [96bf838]
Page Load Metrics (1764 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31922831706359172
domContentLoaded15082199173516378
load15232289176417584
domInteractive14482994
backgroundConnect990352311
firstReactRender482051072914
getState45817178
initialActions00000
loadScripts10771589126612359
setupStore67115178
uiStartup17112535197020297
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 2c9f8c2 Nov 25, 2024
75 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3630-2 branch November 25, 2024 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants