-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reduce max pet name length #28660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
changed the title
Reduce max pet name length
fix: Reduce max pet name length
Nov 22, 2024
Builds ready [79cd7bc]
Page Load Metrics (1824 ± 101 ms)
Bundle size diffs
|
matthewwalsh0
previously approved these changes
Nov 22, 2024
pedronfigueiredo
force-pushed
the
pnf/3630-2
branch
from
November 25, 2024 10:26
79cd7bc
to
96bf838
Compare
Builds ready [96bf838]
Page Load Metrics (1764 ± 84 ms)
Bundle size diffs
|
digiwand
approved these changes
Nov 25, 2024
matthewwalsh0
approved these changes
Nov 25, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on #28560, reduce truncation length to 12 characters instead of 15 (see screenshots).
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3630
Related: #28560
Manual testing steps
Screenshots/Recordings
Before
Max 15 chars
After
Max 12 chars
Pre-merge author checklist
Pre-merge reviewer checklist