Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add e2e for portfolio view polling #28682

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Nov 25, 2024

Description

PR adds an e2e test to check polling activity

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri force-pushed the fix/add-e2e-for-portfolio-view-polling branch from ec39887 to 444b7e5 Compare November 25, 2024 11:29
@sahar-fehri sahar-fehri changed the title Fix/add e2e for portfolio view polling fix: add e2e for portfolio view polling Nov 25, 2024
@sahar-fehri sahar-fehri marked this pull request as ready for review November 25, 2024 16:48
@sahar-fehri sahar-fehri requested review from a team as code owners November 25, 2024 16:48
salimtb
salimtb previously approved these changes Nov 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3bd6c72]
Page Load Metrics (1742 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23226011673414199
domContentLoaded146625751705252121
load148726081742258124
domInteractive2291462110
backgroundConnect11134392814
firstReactRender1681382211
getState5110192512
initialActions01000
loadScripts104720791257227109
setupStore65115157
uiStartup166228531941306147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@@ -29,6 +29,8 @@
"github.com",
"goerli.infura.io",
"lattice.gridplus.io",
"linea-mainnet.infura.io",
"linea-sepolia.infura.io",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add these for the new added e2e because after multichain it is now also making calls to linea mainnet and linea sepolia

@sahar-fehri sahar-fehri added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 0302848 Nov 26, 2024
78 checks passed
@sahar-fehri sahar-fehri deleted the fix/add-e2e-for-portfolio-view-polling branch November 26, 2024 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants