-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add e2e for portfolio view polling #28682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
force-pushed
the
fix/add-e2e-for-portfolio-view-polling
branch
from
November 25, 2024 11:29
ec39887
to
444b7e5
Compare
sahar-fehri
changed the title
Fix/add e2e for portfolio view polling
fix: add e2e for portfolio view polling
Nov 25, 2024
salimtb
reviewed
Nov 25, 2024
salimtb
previously approved these changes
Nov 25, 2024
salimtb
approved these changes
Nov 25, 2024
gambinish
approved these changes
Nov 25, 2024
Builds ready [3bd6c72]
Page Load Metrics (1742 ± 124 ms)
Bundle size diffs
|
sahar-fehri
commented
Nov 26, 2024
@@ -29,6 +29,8 @@ | |||
"github.com", | |||
"goerli.infura.io", | |||
"lattice.gridplus.io", | |||
"linea-mainnet.infura.io", | |||
"linea-sepolia.infura.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add these for the new added e2e because after multichain it is now also making calls to linea mainnet and linea sepolia
pedronfigueiredo
approved these changes
Nov 26, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds an e2e test to check polling activity
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist