Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction flow section layout on re-designed confirmation pages #28720

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 26, 2024

Description

fix: transaction flow section layout on re-designed confirmation pages

Related issues

Ref: #28015

Manual testing steps

  1. Open test dapp
  2. Submit token transfer confirmation
  3. Check layout of the page

Screenshots/Recordings

Before

Screenshot 2024-11-26 at 4 06 28 PM

After

Screenshot 2024-11-26 at 4 06 15 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Nov 26, 2024
@jpuri jpuri requested a review from a team as a code owner November 26, 2024 10:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge November 26, 2024 10:43
@jpuri jpuri added this pull request to the merge queue Nov 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [0a8de95]
Page Load Metrics (1858 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15512114185717081
domContentLoaded15132034181316278
load15622100185816881
domInteractive288739147
backgroundConnect1177382411
firstReactRender1688472512
getState56016188
initialActions01000
loadScripts10721550134614469
setupStore679172010
uiStartup17622423209219594
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 59 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit f64d38f Nov 26, 2024
83 checks passed
@jpuri jpuri deleted the info_sec_fix branch November 26, 2024 11:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants