Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump @metamask/ens-controller from v13 to v14 #28746

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 26, 2024

Description

Bump @metamask/ens-controller to v14. There are two minor breaking changes that impact the constructor and messenger.

Changelog: https://github.com/MetaMask/core/blob/main/packages/ens-controller/CHANGELOG.md#1400

This update resolves a peer dependency warning about the ENS controller's dependence upon the network controller (it was expecting v20, but we had v21).

Open in GitHub Codespaces

Related issues

Relates to https://github.com/MetaMask/MetaMask-planning/issues/3568

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 26, 2024

@metamaskbot update-policies

Copy link

socket-security bot commented Nov 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/ens-controller@14.0.1 None 0 87.8 kB metamaskbot

🚮 Removed packages: npm/@metamask/ens-controller@13.0.1

View full report↗︎

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@Gudahtt Gudahtt marked this pull request as ready for review November 26, 2024 22:33
@Gudahtt Gudahtt requested review from a team as code owners November 26, 2024 22:33
@metamaskbot
Copy link
Collaborator

Builds ready [eeeb8a3]
Page Load Metrics (1658 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14571906165913063
domContentLoaded14481893163012158
load14581910165813163
domInteractive227234115
backgroundConnect886282311
firstReactRender1676392411
getState46215189
initialActions01000
loadScripts10511417119410651
setupStore65212136
uiStartup16522143185514871
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11.45 KiB (-0.19%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Gudahtt and others added 3 commits November 26, 2024 20:54
Bump `@metamask/ens-controller` to v14. There are two minor breaking
changes that impact the constructor and messenger.

Changelog: https://github.com/MetaMask/core/blob/main/packages/ens-controller/CHANGELOG.md#1400

This update resolves a peer dependency warning about the ENS
controller's dependence upon the network controller (it was expecting
v20, but we had v21).
@metamaskbot
Copy link
Collaborator

Builds ready [b8105e1]
Page Load Metrics (1627 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13991962162515876
domContentLoaded13921918159915575
load14001995162716579
domInteractive219031147
backgroundConnect787302412
firstReactRender1680402411
getState446994
initialActions01000
loadScripts9761444114613263
setupStore641974
uiStartup15602248180918287
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -11.45 KiB (-0.20%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 867c7f8 Nov 27, 2024
75 checks passed
@Gudahtt Gudahtt deleted the update-ens-controller-v14 branch November 27, 2024 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-identity team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants