-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump @metamask/ens-controller
from v13 to v14
#28746
Conversation
@metamaskbot update-policies |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/ens-controller@13.0.1 |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [eeeb8a3]
Page Load Metrics (1658 ± 63 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Bump `@metamask/ens-controller` to v14. There are two minor breaking changes that impact the constructor and messenger. Changelog: https://github.com/MetaMask/core/blob/main/packages/ens-controller/CHANGELOG.md#1400 This update resolves a peer dependency warning about the ENS controller's dependence upon the network controller (it was expecting v20, but we had v21).
eeeb8a3
to
b8105e1
Compare
Builds ready [b8105e1]
Page Load Metrics (1627 ± 79 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Bump
@metamask/ens-controller
to v14. There are two minor breaking changes that impact the constructor and messenger.Changelog: https://github.com/MetaMask/core/blob/main/packages/ens-controller/CHANGELOG.md#1400
This update resolves a peer dependency warning about the ENS controller's dependence upon the network controller (it was expecting v20, but we had v21).
Related issues
Relates to https://github.com/MetaMask/MetaMask-planning/issues/3568
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist