-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix transaction list message on token detail page #28764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
salimtb
force-pushed
the
salim/fix-transaction-list-token-details
branch
from
November 27, 2024 10:40
8938823
to
c93ae60
Compare
salimtb
added
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
labels
Nov 27, 2024
Builds ready [c93ae60]
Page Load Metrics (1677 ± 86 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
reviewed
Nov 27, 2024
sahar-fehri
approved these changes
Nov 27, 2024
Builds ready [8486f37]
Page Load Metrics (1722 ± 58 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Nov 27, 2024
Prithpal-Sooriya
approved these changes
Nov 27, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28766
Description
If the token chosen in the token details does not correspond to the current network, the message displayed in the activity section should be updated accordingly.
Related issues
Fixes: #28766
Manual testing steps
PORTFOLIO_VIEW=true yarn start
Screenshots/Recordings
Before
After
fix-2.mov
Pre-merge author checklist
Pre-merge reviewer checklist