Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix transaction list message on token detail page #28764

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 27, 2024

fixes #28766

Description

If the token chosen in the token details does not correspond to the current network, the message displayed in the activity section should be updated accordingly.

Open in GitHub Codespaces

Related issues

Fixes: #28766

Manual testing steps

  1. run PORTFOLIO_VIEW=true yarn start
  2. choose any token who is not part of current network and go to token details
  3. go to activity section and check the message

Screenshots/Recordings

Before

After

fix-2.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/fix-transaction-list-token-details branch from 8938823 to c93ae60 Compare November 27, 2024 10:40
@salimtb salimtb added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. portfolio-view Used for PRs and issues related to Q4 2024 portfolio view labels Nov 27, 2024
@salimtb salimtb marked this pull request as ready for review November 27, 2024 11:05
@salimtb salimtb requested a review from a team as a code owner November 27, 2024 11:05
@metamaskbot
Copy link
Collaborator

Builds ready [c93ae60]
Page Load Metrics (1677 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14582017167316680
domContentLoaded14201998164316278
load14302020167717986
domInteractive225531105
backgroundConnect791352612
firstReactRender1676312010
getState44919178
initialActions01000
loadScripts10341533121614670
setupStore55110105
uiStartup160522831871211101
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 433 Bytes (0.01%)
  • common: 217 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [8486f37]
Page Load Metrics (1722 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30420201538486233
domContentLoaded15212007169511957
load15322018172212258
domInteractive237640157
backgroundConnect118030178
firstReactRender1772372211
getState56812168
initialActions01000
loadScripts11081554126210852
setupStore65715168
uiStartup17302245193112761
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 448 Bytes (0.01%)
  • common: 217 Bytes (0.00%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit ddb4c97 Nov 27, 2024
75 checks passed
@NidhiKJha NidhiKJha deleted the salim/fix-transaction-list-token-details branch November 27, 2024 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension: Portfolio View: Update activity list copy on Token Details
5 participants