Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-overview): prevent send button clicked event to be sent twice #28772

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Nov 27, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

N/A (being covered by unit tests)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly requested a review from a team as a code owner November 27, 2024 14:23
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly force-pushed the fix/event-send-button-clicked-twice branch from 2d065b2 to 69e5153 Compare November 27, 2024 14:55
@ccharly ccharly added this pull request to the merge queue Nov 27, 2024
@ccharly ccharly removed this pull request from the merge queue due to a manual request Nov 27, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [69e5153]
Page Load Metrics (1786 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15272128179516378
domContentLoaded15182080176114770
load15342141178615373
domInteractive268843209
backgroundConnect780332010
firstReactRender1584392612
getState466202010
initialActions01000
loadScripts10191571128112560
setupStore65714147
uiStartup17182311198216378
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -199 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@ccharly ccharly added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 70b017a Nov 27, 2024
75 checks passed
@ccharly ccharly deleted the fix/event-send-button-clicked-twice branch November 27, 2024 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants