From a3942540b7591a5175c520299b12aa987f13a4bc Mon Sep 17 00:00:00 2001 From: Charly Chevalier Date: Wed, 27 Nov 2024 15:20:30 +0100 Subject: [PATCH 1/2] test(wallet-overview): make sure events are sent only once --- ui/components/app/wallet-overview/eth-overview.test.js | 2 ++ ui/components/app/wallet-overview/non-evm-overview.test.tsx | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ui/components/app/wallet-overview/eth-overview.test.js b/ui/components/app/wallet-overview/eth-overview.test.js index 5af6990d4499..104764251cf8 100644 --- a/ui/components/app/wallet-overview/eth-overview.test.js +++ b/ui/components/app/wallet-overview/eth-overview.test.js @@ -445,6 +445,7 @@ describe('EthOverview', () => { expect(buyButton).not.toBeDisabled(); fireEvent.click(buyButton); + expect(mockTrackEvent).toHaveBeenCalledTimes(1); expect(mockTrackEvent).toHaveBeenCalledWith({ event: MetaMetricsEventName.NavBuyButtonClicked, category: MetaMetricsEventCategory.Navigation, @@ -539,6 +540,7 @@ describe('EthOverview', () => { expect(sendButton).not.toBeDisabled(); fireEvent.click(sendButton); + expect(mockTrackEvent).toHaveBeenCalledTimes(1); expect(mockTrackEvent).toHaveBeenCalledWith( { event: MetaMetricsEventName.NavSendButtonClicked, diff --git a/ui/components/app/wallet-overview/non-evm-overview.test.tsx b/ui/components/app/wallet-overview/non-evm-overview.test.tsx index aa49eb77e79d..cfffb9bdc7ce 100644 --- a/ui/components/app/wallet-overview/non-evm-overview.test.tsx +++ b/ui/components/app/wallet-overview/non-evm-overview.test.tsx @@ -305,6 +305,7 @@ describe('NonEvmOverview', () => { expect(buyButton).not.toBeDisabled(); fireEvent.click(buyButton as HTMLElement); + expect(mockTrackEvent).toHaveBeenCalledTimes(1); expect(mockTrackEvent).toHaveBeenCalledWith({ event: MetaMetricsEventName.NavBuyButtonClicked, category: MetaMetricsEventCategory.Navigation, @@ -381,6 +382,7 @@ describe('NonEvmOverview', () => { expect(sendButton).not.toBeDisabled(); fireEvent.click(sendButton as HTMLElement); + expect(mockTrackEvent).toHaveBeenCalledTimes(1); expect(mockTrackEvent).toHaveBeenCalledWith( { event: MetaMetricsEventName.NavSendButtonClicked, From 69e5153843722e01c37365ce19804c8fa0102750 Mon Sep 17 00:00:00 2001 From: Charly Chevalier Date: Wed, 27 Nov 2024 15:21:33 +0100 Subject: [PATCH 2/2] fix(wallet-overview): prevent from sending SendButtonClicked twice for EVM accounts --- ui/components/app/wallet-overview/coin-buttons.tsx | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/ui/components/app/wallet-overview/coin-buttons.tsx b/ui/components/app/wallet-overview/coin-buttons.tsx index c3708eaef344..a19811cd710e 100644 --- a/ui/components/app/wallet-overview/coin-buttons.tsx +++ b/ui/components/app/wallet-overview/coin-buttons.tsx @@ -375,19 +375,6 @@ const CoinButtons = ({ } ///: END:ONLY_INCLUDE_IF default: { - trackEvent( - { - event: MetaMetricsEventName.NavSendButtonClicked, - category: MetaMetricsEventCategory.Navigation, - properties: { - token_symbol: 'ETH', - location: 'Home', - text: 'Send', - chain_id: chainId, - }, - }, - { excludeMetaMetricsId: false }, - ); await setCorrectChain(); await dispatch(startNewDraftTransaction({ type: AssetType.native })); history.push(SEND_ROUTE);