Skip to content

Conversation

@jiexi
Copy link
Contributor

@jiexi jiexi commented Mar 17, 2025

Description

Bumps the @metamask/providers package to ^21.0.0 and adopts necessary changes to usage

Open in GitHub Codespaces

Related issues

See: MetaMask/providers#410

Manual testing steps

No user facing changes. Visit any dapp and use it as before.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Mar 17, 2025
@jiexi jiexi changed the title WIP: Bump @metamask/providers feat: bump @metamask/providers to ^21.0.0 Mar 21, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3a00338]
Page Load Metrics (2597 ± 527 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37456292307956459
domContentLoaded165548512184708340
load1727681025971097527
domInteractive25251586029
backgroundConnect741878404411197
firstReactRender413001046632
getState38913209224107
initialActions01000
loadScripts119733371548461221
setupStore161237154262126
uiStartup244916353497534751668
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -547 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Mar 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [46bd819]
Page Load Metrics (2745 ± 1026 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17461025126051894909
domContentLoaded1648884323941623779
load175811419274521381026
domInteractive26210584421
backgroundConnect472384350496238
firstReactRender20150714019
getState1148512611254
initialActions01000
loadScripts1174710817191288618
setupStore13215534823
uiStartup199611826395723891147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -547 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

adonesky1
adonesky1 previously approved these changes Mar 25, 2025
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jiexi added 2 commits April 9, 2025 15:39
@metamaskbot
Copy link
Collaborator

Builds ready [d12bfb5]
UI Startup Metrics (1210 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1210109313746012541312
load10569081188621171991
domContentLoaded10509031177621164987
domInteractive16136271629
firstPaint5631291184413244973
backgroundConnect7426379
firstReactRender20157072033
getState13537879
initialActions001001
loadScripts81166794361853920
setupStore8520378
WebpackHomeuiStartup21951781249417123232406
load17241275216815117911975
domContentLoaded17171268216415017841970
domInteractive171264111449
firstPaint17568173216821382
backgroundConnect35933142429
firstReactRender169533721135887
getState2743485948
initialActions317145
loadScripts17121265216114817821940
setupStore23618233299
FirefoxBrowserifyHomeuiStartup13431158182213313721646
load12021041168813112481499
domContentLoaded12011041168813112481499
domInteractive10439344448997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2013236222027
firstReactRender23185772245
getState7436579
initialActions001001
loadScripts11831027166913012301485
setupStore842022067
WebpackHomeuiStartup15361367187610416071709
load1330117215799314031524
domContentLoaded1330117115799314021523
domInteractive9756166228895
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20143842229
firstReactRender34294943643
getState8430489
initialActions002111
loadScripts1311114515669413861509
setupStore7529389

adonesky1
adonesky1 previously approved these changes Apr 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4812a88]
UI Startup Metrics (1216 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1216111314776412491325
load105394912795910801146
domContentLoaded104794512755810731140
domInteractive17136371629
firstPaint69167125942910661141
backgroundConnect74203712
firstReactRender20163132029
getState1464082031
initialActions001001
loadScripts810714102056835906
setupStore84202813
WebpackHomeuiStartup20801688248517021982315
load16091319192012417061783
domContentLoaded16031316189912316991778
domInteractive151157101349
firstPaint193661524148216329
backgroundConnect23974142555
firstReactRender19155390118323355
getState1142751323
initialActions316135
loadScripts15951314187612216951772
setupStore1663971932
FirefoxBrowserifyHomeuiStartup1342116816658813941490
load1201102415439712611359
domContentLoaded1200102415429712601358
domInteractive1043823835121164
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19137581935
firstReactRender22195452226
getState7321279
initialActions001001
loadScripts1183100615289812471332
setupStore6417267
WebpackHomeuiStartup15171324209415015671899
load12941147184213213321616
domContentLoaded12941147184213213311616
domInteractive80401712388134
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2715277272646
firstReactRender35286063747
getState104326929
initialActions102111
loadScripts12701124182812413141554
setupStore85525812
cc: @HowardBraham
Benchmark value 193 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 329 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 45 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 19ms | Sum of p95 exceeds: 20ms
Sum of all benchmark exceeds: 39ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: -404 Bytes (-0.01%)
  • common: 0 Bytes (0%)

@jiexi jiexi added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 17, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 18, 2025
@jiexi jiexi added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit 2068949 Apr 18, 2025
170 of 171 checks passed
@jiexi jiexi deleted the jl/remove-substream-instantiation-metamask-providers branch April 18, 2025 16:11
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants