-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: bump @metamask/providers to ^21.0.0
#31056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump @metamask/providers to ^21.0.0
#31056
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@metamask/providers@metamask/providers to ^21.0.0
Builds ready [3a00338]
Page Load Metrics (2597 ± 527 ms)
Bundle size diffs
|
Builds ready [46bd819]
Page Load Metrics (2745 ± 1026 ms)
Bundle size diffs
|
adonesky1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…n-metamask-providers' into jl/remove-substream-instantiation-metamask-providers
Builds ready [d12bfb5]
UI Startup Metrics (1210 ± 60 ms)
|
Builds ready [4812a88]
UI Startup Metrics (1216 ± 64 ms)
Benchmark value 193 exceeds gate value 175 for chrome webpack home mean firstPaint Benchmark value 329 exceeds gate value 310 for chrome webpack home p95 firstPaint Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 45 for firefox webpack home p95 backgroundConnect Sum of mean exceeds: 19ms | Sum of p95 exceeds: 20ms Sum of all benchmark exceeds: 39ms Bundle size diffs
|
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Bumps the
@metamask/providerspackage to^21.0.0and adopts necessary changes to usageRelated issues
See: MetaMask/providers#410
Manual testing steps
No user facing changes. Visit any dapp and use it as before.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist