fix: flaky test Settings - general tab validate "मानक हिन्दी" language on tooltips

[seaona]

Description

In some of the change language specs, we change the language and immediately click the close settings button. This action can have no effect, if we click before the language is changes, as then there's a re-render and we are still in the settings page.

We need to wait until the language has been changed before proceeding with the next action. For that, we add a check to make sure the language has changed, every time we perform a changeLanguage action.

ci failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/134139/workflows/c284f602-6903-4a81-a0ac-48a05f987ee7/jobs/4696447/tests

Related issues

Fixes:

Manual testing steps

1. Check ci

Screenshots/Recordings

See in the failure artifacts, how after clicking close settings, we still remain in the settings page. The click was performed but took no effect, as after that the page was re-rendered with the new language.
Then we try to look for an element from the home page but that can't be found as we are still in settings

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [c3d11c0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1204 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1204	1085	1442	61	1240	1326
			load	1051	946	1221	57	1184	989
			domContentLoaded	1045	940	1215	57	1187	984
			domInteractive	16	13	32	4	16	27
			firstPaint	803	79	1222	393	248	984
			backgroundConnect	10	6	33	4	9	10
			firstReactRender	18	14	32	3	19	24
			getState	11	5	32	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	830	727	983	56	872	932
			setupStore	7	5	17	2	7	8
	Webpack	Home	uiStartup	955	777	1286	88	966	982
			load	816	648	1024	61	850	896
			domContentLoaded	810	644	1011	60	843	891
			domInteractive	16	12	71	9	14	36
			firstPaint	450	61	1015	339	833	871
			backgroundConnect	16	10	39	7	15	36
			firstReactRender	14	12	31	4	13	25
			getState	7	4	11	1	7	9
			initialActions	0	0	1	0	0	0
			loadScripts	808	643	1001	59	842	890
			setupStore	7	4	14	2	7	9
Firefox	Browserify	Home	uiStartup	1349	1177	1980	162	1366	1748
			load	1212	1047	1793	152	1247	1591
			domContentLoaded	1212	1046	1793	152	1247	1591
			domInteractive	98	40	168	22	90	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	206	22	22	34
			firstReactRender	23	18	76	7	25	30
			getState	6	3	21	2	7	7
			initialActions	0	0	1	0	0	1
			loadScripts	1189	1030	1755	147	1228	1563
			setupStore	6	3	12	2	6	7
	Webpack	Home	uiStartup	992	832	1546	180	895	974
			load	870	728	1370	159	819	930
			domContentLoaded	869	728	1370	159	818	930
			domInteractive	112	36	207	25	60	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	12	97	15	23	62
			firstReactRender	18	16	24	2	18	23
			getState	8	4	67	7	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	852	715	1340	155	805	916
			setupStore	8	4	64	8	7	8

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[chloeYue]

LGTM! Thanks for the fix !