From d9f52b4c69dcfb9e3e62cbfd30713a9acab52664 Mon Sep 17 00:00:00 2001 From: Guillaume Roux Date: Fri, 28 Mar 2025 12:34:23 +0100 Subject: [PATCH] Revert "fix: Confirmation responsiveness inconsistencies (redesign, Snaps, multichain, permissions-connect, confirmations-page) (#31058)" This reverts commit 3c68f3f2c70a00c65a5aa113871c248df011ab5d. --- .storybook/index.css | 4 +- test/e2e/snaps/test-snap-dialog.spec.js | 12 ----- .../__snapshots__/nft-details.test.js.snap | 2 +- .../__snapshots__/nft-full-image.test.js.snap | 2 +- .../info/row/__snapshots__/row.test.tsx.snap | 4 +- ui/components/app/confirm/info/row/row.tsx | 7 +-- .../app/permission-page-container/index.scss | 4 -- ...ission-page-container-content.component.js | 1 - .../snap-ui-renderer.test.js.snap | 48 +++++++++---------- .../snap-ui-renderer/components/footer.ts | 2 + .../app/snaps/snap-ui-renderer/index.scss | 2 - .../snap-ui-renderer/snap-ui-renderer.js | 5 ++ .../update-snap-permission-list.js | 3 +- .../multichain/app-header/index.scss | 2 - .../create-named-snap-account.tsx | 10 +--- .../create-named-snap-account/index.scss | 2 - .../notification-list-item/index.scss | 1 - .../multichain/pages/page/index.scss | 39 --------------- ui/components/multichain/pages/page/page.tsx | 11 +---- .../permissions-page.test.js.snap | 2 +- .../review-permissions-page.test.tsx.snap | 2 +- .../send/__snapshots__/send.test.js.snap | 2 +- .../multichain/pages/send/index.scss | 22 ++------- .../ui/deprecated-networks/index.scss | 2 - ui/components/ui/page-container/index.scss | 21 +------- ui/css/itcss/components/newui-sections.scss | 17 ++----- .../info/__snapshots__/info.test.tsx.snap | 8 ++-- .../__snapshots__/approve.test.tsx.snap | 4 +- .../__snapshots__/personal-sign.test.tsx.snap | 8 ++-- .../__snapshots__/siwe-sign.test.tsx.snap | 18 +++---- .../info/personal-sign/siwe-sign/index.scss | 8 ---- .../personal-sign/siwe-sign/siwe-sign.tsx | 12 ++--- .../transaction-data.test.tsx.snap | 16 +++---- .../__snapshots__/typed-sign-v1.test.tsx.snap | 4 +- .../__snapshots__/typed-sign.test.tsx.snap | 20 ++++---- .../__snapshots__/snaps-section.test.tsx.snap | 4 +- ui/pages/confirmations/components/index.scss | 1 - .../__snapshots__/confirm.test.tsx.snap | 44 ++++++++--------- ui/pages/confirmations/confirm/index.scss | 25 ++-------- .../confirmation/confirmation.js | 21 +------- .../confirmation/confirmation.scss | 31 +----------- .../confirmation/stories/success.stories.js | 3 +- .../confirmation/stories/util.js | 20 +------- .../create-named-snap-account.test.js.snap | 6 +-- .../create-snap-account.test.js.snap | 8 ++-- .../remove-snap-account.test.js.snap | 10 ++-- .../snap-account-redirect.test.js.snap | 6 +-- .../create-snap-account.tsx | 6 +-- ui/pages/create-snap-account/index.scss | 3 -- ui/pages/home/home.component.js | 2 +- .../__snapshots__/connect-page.test.tsx.snap | 8 ++-- .../connect-page/connect-page.tsx | 7 +-- ui/pages/permissions-connect/index.scss | 34 +------------ .../permissions-connect.stories.js | 9 +--- .../permissions-redirect.component.js | 4 -- .../snaps/snap-install/index.scss | 3 +- .../snaps/snap-install/snap-install.js | 3 +- .../snaps/snap-result/index.scss | 8 +--- .../snaps/snap-result/snap-result.js | 8 ++-- .../snaps/snap-update/index.scss | 3 +- .../snaps/snap-update/snap-update.js | 3 +- .../snaps/snaps-connect/index.scss | 3 -- .../snaps/snaps-connect/snaps-connect.js | 6 +-- ui/pages/remove-snap-account/index.scss | 3 -- .../remove-snap-account.tsx | 12 ++--- ui/pages/settings/settings.component.js | 9 ++-- .../create-snap-redirect.test.tsx.snap | 4 +- .../snap-account-redirect-context.tsx | 1 - .../snap-account-redirect.tsx | 3 +- ui/pages/snaps/snap-view/index.scss | 2 - ui/pages/snaps/snap-view/snap-view.js | 7 ++- ui/pages/snaps/snaps-list/index.scss | 2 - 72 files changed, 188 insertions(+), 471 deletions(-) delete mode 100644 ui/pages/confirmations/components/confirm/info/personal-sign/siwe-sign/index.scss diff --git a/.storybook/index.css b/.storybook/index.css index 3c0301c5c2b0..48ebae78fe46 100644 --- a/.storybook/index.css +++ b/.storybook/index.css @@ -9,8 +9,8 @@ margin-top: auto !important; } -.snap-ui-renderer__content { - margin-bottom: 0 !important; +.snap-ui-renderer__container { + padding-bottom: 0 !important; } .snap-ui-renderer__panel { diff --git a/test/e2e/snaps/test-snap-dialog.spec.js b/test/e2e/snaps/test-snap-dialog.spec.js index e799c4596e6c..a893be4847b4 100644 --- a/test/e2e/snaps/test-snap-dialog.spec.js +++ b/test/e2e/snaps/test-snap-dialog.spec.js @@ -45,9 +45,6 @@ describe('Test Snap Dialog', function () { tag: 'button', }); - // click and dismiss possible scroll element - await driver.clickElementSafe('[data-testid="snap-install-scroll"]'); - // wait for and click confirm await driver.waitForSelector({ text: 'Confirm' }); await driver.clickElement({ @@ -151,9 +148,6 @@ describe('Test Snap Dialog', function () { // switch to dialog popup await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog); - // click and dismiss possible scroll element - await driver.clickElementSafe('[data-testid="snap-install-scroll"]'); - // click cancel button and wait for window to close await driver.clickElementAndWaitForWindowToClose({ text: 'Cancel', @@ -200,9 +194,6 @@ describe('Test Snap Dialog', function () { // switch to dialog popup await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog); - // click and dismiss possible scroll element - await driver.clickElementSafe('[data-testid="snap-install-scroll"]'); - // click cancel button and wait for window to close await driver.clickElementAndWaitForWindowToClose({ text: 'Cancel', @@ -227,9 +218,6 @@ describe('Test Snap Dialog', function () { // fill '2323' in form field await driver.pasteIntoField('#custom-input', '2323'); - // click and dismiss possible scroll element - await driver.clickElementSafe('[data-testid="snap-install-scroll"]'); - // click confirm button and wait for window to close await driver.clickElementAndWaitForWindowToClose({ text: 'Confirm', diff --git a/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap b/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap index 4479223ec064..32778e3b60f9 100644 --- a/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap +++ b/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap @@ -3,7 +3,7 @@ exports[`NFT Details should match minimal props and state snapshot 1`] = `
= ({ const isCollapsible = collapsed !== undefined; - const contentPaddingRight = ((copyEnabled ? 6 : 0) + - (isCollapsible ? 6 : 0)) as SizeNumber; - return ( = ({ marginTop={2} marginBottom={2} paddingLeft={2} - paddingRight={2} + paddingRight={copyEnabled ? 5 : 2} color={TEXT_COLORS[variant] as TextColor} style={{ overflowWrap: OverflowWrap.Anywhere, @@ -146,7 +142,6 @@ export const ConfirmInfoRow: React.FC = ({ justifyContent={JustifyContent.center} alignItems={AlignItems.flexStart} color={color} - paddingRight={contentPaddingRight || null} > diff --git a/ui/components/app/permission-page-container/index.scss b/ui/components/app/permission-page-container/index.scss index 2d6a4a7b9460..118a9ff639fa 100644 --- a/ui/components/app/permission-page-container/index.scss +++ b/ui/components/app/permission-page-container/index.scss @@ -1,7 +1,3 @@ -.permission-page-container-content { - flex: '1 0 auto'; -} - .permission-page-container-footer { border-top: none !important; } diff --git a/ui/components/app/permission-page-container/permission-page-container-content/permission-page-container-content.component.js b/ui/components/app/permission-page-container/permission-page-container-content/permission-page-container-content.component.js index ae3863d752d4..4f4f4264fa88 100644 --- a/ui/components/app/permission-page-container/permission-page-container-content/permission-page-container-content.component.js +++ b/ui/components/app/permission-page-container/permission-page-container-content/permission-page-container-content.component.js @@ -65,7 +65,6 @@ export default class PermissionPageContainerContent extends PureComponent { subjectType === SubjectType.Website ? getURLHost(origin) : origin; return (