Skip to content

Conversation

@jiexi
Copy link
Contributor

@jiexi jiexi commented Apr 17, 2025

Description

Adds the last bit needed to get solana wallet standard provider working with firefox

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. yarn start:flask:mv2
  2. In Firefox, add a solana account
  3. Visit jup.ag, Swap some tokens
  4. Should work as expected (except currently there is a regression in main preventing solana signing from working)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Apr 17, 2025
@socket-security
Copy link

socket-security bot commented Apr 17, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​multichain-api-client@​0.1.1 ⏵ 0.2.0100 +27100100 +3100 +9100

View full report

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 enabled auto-merge April 17, 2025 19:41
@adonesky1 adonesky1 added this pull request to the merge queue Apr 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [1e20447]
UI Startup Metrics (1223 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1223110514366212601339
load105895911985810921187
domContentLoaded105295411915810861176
domInteractive17133041628
firstPaint67978119742410651167
backgroundConnect7433379
firstReactRender20154752031
getState1253581828
initialActions001001
loadScripts81272695255837930
setupStore75202812
WebpackHomeuiStartup21901715258115823122411
load16991379202712217841891
domContentLoaded16921374200212117781881
domInteractive161158101344
firstPaint1887835260234313
backgroundConnect261074133157
firstReactRender22756398119334364
getState1243761524
initialActions318146
loadScripts16871372197912117731879
setupStore227294332336
FirefoxBrowserifyHomeuiStartup13381177180511113911557
load11931029166011612621436
domContentLoaded11931029165911612621435
domInteractive1084038150113200
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2312102152051
firstReactRender22193832226
getState7429379
initialActions001001
loadScripts11731011156211412471419
setupStore6344468
WebpackHomeuiStartup15231366205012715811785
load1299116515939913671512
domContentLoaded12991164159210013671511
domInteractive83332763188154
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23144872640
firstReactRender36295753847
getState124336331021
initialActions102111
loadScripts1279115015749913481488
setupStore95365920
Benchmark value 188 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 313 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 200 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 13ms | Sum of p95 exceeds: 8ms
Sum of all benchmark exceeds: 21ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7249ef2]
UI Startup Metrics (1215 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1215110813745612411337
load105295611855610861148
domContentLoaded104595111805510791141
domInteractive17136661627
firstPaint72881118041410711130
backgroundConnect74223814
firstReactRender20164452033
getState1344181928
initialActions002001
loadScripts80571593353844892
setupStore75172912
WebpackHomeuiStartup20951693262619222062467
load16151310213114917061912
domContentLoaded16081307212414717001881
domInteractive161153101348
firstPaint1856537463223309
backgroundConnect24983142659
firstReactRender21755364114336357
getState1244171329
initialActions316135
loadScripts16031305210214516991857
setupStore217308342035
FirefoxBrowserifyHomeuiStartup13511194172910614181554
load12081024157511512951428
domContentLoaded12081023157511512941427
domInteractive1013932040117163
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2212100152062
firstReactRender22192822227
getState7413279
initialActions001001
loadScripts11881005150911312781412
setupStore6436367
WebpackHomeuiStartup14961274191412115651756
load12861094172611213501465
domContentLoaded12861094172511213501464
domInteractive79371842287126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19145352026
firstReactRender34295143541
getState75294811
initialActions103111
loadScripts12681079170711213351446
setupStore75384810
Benchmark value 185 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 2468 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Sum of mean exceeds: 10ms | Sum of p95 exceeds: 14ms
Sum of all benchmark exceeds: 24ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Merged via the queue into main with commit 068563d Apr 17, 2025
167 of 169 checks passed
@jiexi jiexi deleted the jl/bump-multichain-api-client-0.2.0 branch April 17, 2025 22:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants