-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: rename migration 154 to 152.1 #32109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
reviewed
Apr 17, 2025
adonesky1
previously approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non blocking comment
jiexi
approved these changes
Apr 17, 2025
adonesky1
approved these changes
Apr 17, 2025
Builds ready [a51e2b8]
UI Startup Metrics (1218 ± 74 ms)
Benchmark value 942 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 197 exceeds gate value 175 for chrome webpack home mean firstPaint Benchmark value 325 exceeds gate value 310 for chrome webpack home p95 firstPaint Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 1678 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1677 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1650 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 23ms | Sum of p95 exceeds: 72ms Sum of all benchmark exceeds: 95ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
team-accounts-framework
Accounts Framework team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the migration 154 to 152.1
Related issues
Fixes: None
Manual testing steps
Not required
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist