Skip to content

Conversation

@gantunesr
Copy link
Member

@gantunesr gantunesr commented Apr 17, 2025

Description

Open in GitHub Codespaces

Renames the migration 154 to 152.1

Related issues

Fixes: None

Manual testing steps

Not required

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr marked this pull request as ready for review April 17, 2025 20:39
@gantunesr gantunesr added team-accounts-framework Accounts Framework team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Apr 17, 2025
adonesky1
adonesky1 previously approved these changes Apr 17, 2025
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non blocking comment

@gantunesr gantunesr enabled auto-merge April 17, 2025 21:10
@gantunesr gantunesr added this pull request to the merge queue Apr 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a51e2b8]
UI Startup Metrics (1218 ± 74 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1218109915577412581337
load105793513677110921182
domContentLoaded105093113607010861176
domInteractive17136171631
firstPaint749133120841410691158
backgroundConnect74142810
firstReactRender20163642125
getState1353871730
initialActions002001
loadScripts814704110369849941
setupStore75152811
WebpackHomeuiStartup21031672268118322242357
load16211341204314117381844
domContentLoaded16141335202013917291823
domInteractive15114591341
firstPaint197701765172226324
backgroundConnect299335382670
firstReactRender20455388124342357
getState144271271331
initialActions317145
loadScripts16091333199613817271821
setupStore177234221925
FirefoxBrowserifyHomeuiStartup13911189171111214551637
load12381060158611312971486
domContentLoaded12371059158611312961486
domInteractive1103731046120187
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211391102136
firstReactRender24195562541
getState9415715812
initialActions001001
loadScripts12191045157111212781471
setupStore6413268
WebpackHomeuiStartup15391335200414916111911
load13171152174813113931678
domContentLoaded13171151174713113931677
domInteractive84342302799132
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154252233
firstReactRender35295653645
getState85324815
initialActions001011
loadScripts12991132173113013771650
setupStore10528828810
cc: @HowardBraham
Benchmark value 942 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 197 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 325 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 1678 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1677 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1650 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 23ms | Sum of p95 exceeds: 72ms
Sum of all benchmark exceeds: 95ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 8 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Merged via the queue into main with commit e4bd6ee Apr 17, 2025
169 checks passed
@gantunesr gantunesr deleted the gar/chore/rename-mig-154 branch April 17, 2025 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants