Skip to content

Conversation

@Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Apr 25, 2025

Description

This ensures we handle better native token display names when you bridge or swap tokens for networks you have removed or not added.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2293

Manual testing steps

  1. Add BASE network (if you have native tokens in base, otherwise use a different network you have native tokens for)
  2. Try to bridge to BASE - you should see the native token
  3. Remove BASE
  4. Try to bridge to BASE - you should see the correct native token still displayed

Screenshots/Recordings

Before

https://www.loom.com/share/812617be0e6e4101b777ff56c367ce0a

After

https://www.loom.com/share/1df5613c2b274314b2839bc143a3cbad?sid=a7776357-eab8-473d-b2a6-2da71f3c4107

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the fix/native-token-when-bridging-a-network-removed branch from 829642d to 7e18ff3 Compare April 25, 2025 14:36
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Apr 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7e18ff3]
UI Startup Metrics (1192 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1192110214185612231299
load102894512284910571126
domContentLoaded102294112174710501118
domInteractive17137671628
firstPaint69173114540510381091
backgroundConnect7458579
firstReactRender20154052133
getState1353471827
initialActions001001
loadScripts78570795546817858
setupStore85162812
WebpackHomeuiStartup24281984284817225472714
load19191499258421420292334
domContentLoaded19121495258021420182330
domInteractive191373121756
firstPaint2007747974252335
backgroundConnect4012264454596
firstReactRender18360386114303352
getState214221342137
initialActions328247
loadScripts19061493257821620132328
setupStore287275432960
FirefoxBrowserifyHomeuiStartup13711181171610814391567
load12191035156510912861410
domContentLoaded12191035156410912861409
domInteractive1144026240130219
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313226232251
firstReactRender23194942328
getState74283812
initialActions001001
loadScripts12001022154610912671390
setupStore6429368
WebpackHomeuiStartup15281350197613616181810
load13091160178312213971526
domContentLoaded13091160178312213971526
domInteractive86394013795124
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2214102112340
firstReactRender362910083847
getState84273912
initialActions002111
loadScripts12891145176612113771512
setupStore95416822
cc: @HowardBraham
Benchmark value 2428 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1920 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1912 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 201 exceeds gate value 199 for chrome webpack home mean firstPaint
Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1907 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2714 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2334 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2330 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 97 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 2328 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 868ms | Sum of p95 exceeds: 1279ms
Sum of all benchmark exceeds: 2147ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 37 Bytes (0%)

Merged via the queue into main with commit a82b45d Apr 25, 2025
172 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix/native-token-when-bridging-a-network-removed branch April 25, 2025 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants