-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: provide better native token names when bridging and swapping removed networks #32293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Prithpal-Sooriya
merged 1 commit into
main
from
fix/native-token-when-bridging-a-network-removed
Apr 25, 2025
Merged
fix: provide better native token names when bridging and swapping removed networks #32293
Prithpal-Sooriya
merged 1 commit into
main
from
fix/native-token-when-bridging-a-network-removed
Apr 25, 2025
+111
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
829642d to
7e18ff3
Compare
sahar-fehri
approved these changes
Apr 25, 2025
gambinish
approved these changes
Apr 25, 2025
Builds ready [7e18ff3]
UI Startup Metrics (1192 ± 56 ms)
Benchmark value 2428 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1920 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1912 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 201 exceeds gate value 199 for chrome webpack home mean firstPaint Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1907 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2714 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2334 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2330 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 97 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 2328 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive Sum of mean exceeds: 868ms | Sum of p95 exceeds: 1279ms Sum of all benchmark exceeds: 2147ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures we handle better native token display names when you bridge or swap tokens for networks you have removed or not added.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2293
Manual testing steps
Screenshots/Recordings
Before
https://www.loom.com/share/812617be0e6e4101b777ff56c367ce0a
After
https://www.loom.com/share/1df5613c2b274314b2839bc143a3cbad?sid=a7776357-eab8-473d-b2a6-2da71f3c4107
Pre-merge author checklist
Pre-merge reviewer checklist