feat: Ledger forget device e2e tests #35463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove the unusaed imports in trezor-forget-device.spec.ts
dawnseeker8
added
team-accounts-framework
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [edea27f]
UI Startup Metrics (1219 ± 64 ms)
Benchmark value 1066 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 257 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2496 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 379 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 206 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 256 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 300ms | Sum of p95 exceeds: 529.8ms Sum of all benchmark exceeds: 829.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [622fb3d]
UI Startup Metrics (1192 ± 64 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 270 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 252 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 230 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 41 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 270ms | Sum of p95 exceeds: 689.8ms Sum of all benchmark exceeds: 959.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…Page This commit modifies the `clickContinueButton` method to first wait for the continue button to be visible before clicking it. The updated interaction now ensures that the button is clicked only after it has disappeared, improving the reliability of the user experience.
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +2 -1)
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [6b48326]
UI Startup Metrics (1181 ± 60 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 252 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 264 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 267 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1242 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1667 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 246 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 276 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 294ms | Sum of p95 exceeds: 723.8ms Sum of all benchmark exceeds: 1017.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [917bf04]
UI Startup Metrics (1188 ± 61 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 256 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2533 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 202 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1388 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1388 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1365 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 304ms | Sum of p95 exceeds: 610.8ms Sum of all benchmark exceeds: 914.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
dawnseeker8
commented
Aug 29, 2025
|
|
||
| // if browser is firefox | ||
| if (isFirefox) { | ||
| await connectHardwareWalletPage.checkFirefoxNotSupportedIsDisplayed(); |
Contributor
Author
There was a problem hiding this comment.
Ledger connection screen doesnt support ledger hardware device due to firefox doesnt support HID usb connection.
Akaryatrh
approved these changes
Aug 29, 2025
seaona
approved these changes
Sep 2, 2025
Member
seaona
left a comment
seaona
left a comment
There was a problem hiding this comment.
Overall LGTM. I left a non-blocking comment, in case it makes sense and you might carry it over your next work 🙏
| await connectHardwareWalletPage.checkPageIsLoaded(); | ||
| await connectHardwareWalletPage.clickConnectLedgerButton(); | ||
|
|
||
| // if browser is firefox |
Member
There was a problem hiding this comment.
Non blocking: I think a comment explaining why we do this, like the one you added below would be more clarifying:
Ledger connection screen doesnt support ledger hardware device due to firefox doesnt support HID usb connection.
Maybe if you have the chance to add it in another PR, that would be good!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implemented a e2e tests for Ledger
forget devicefeatures.Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist