chore: AccountTrackerController migration #36808
Merged
+269
−4,280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +0 -15)
🧩 @MetaMask/extension-devs (5 files, +6 -5)
📜 @MetaMask/policy-reviewers (5 files, +6 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +6 -5)
👨🔧 @MetaMask/wallet-integrations (2 files, +6 -16)
|
bergarces
commented
Oct 17, 2025
| useExternalServices: true, | ||
| // from core PreferencesController | ||
| isMultiAccountBalancesEnabled: true, | ||
| useMultiAccountBalanceChecker: true, |
Contributor
Author
There was a problem hiding this comment.
Putting them together as it'll be easier to remove one when we eventually migrate to the core PreferencesController. For now, and considering this PR is already big enough, we are keeping both.
bergarces
commented
Oct 17, 2025
| */ | ||
| export function getKeyringControllerMessenger( | ||
| messenger: Messenger<AllowedActions, AllowedEvents>, | ||
| messenger: Messenger<never, never>, |
Contributor
Author
There was a problem hiding this comment.
It was using the wrong types from a different controller. KeyringController does not require any AllowedActions or AllowedEvents
bergarces
commented
Oct 17, 2025
| networkClientId, | ||
| ); | ||
| }, | ||
| includeStakedAssets: false, |
Contributor
Author
There was a problem hiding this comment.
Not part of this PR to include staked assets in the assets list. When we want to enable them, we can do so.
bergarces
commented
Oct 17, 2025
| setUseMultiAccountBalanceChecker(val: boolean): void { | ||
| this.update((state) => { | ||
| state.useMultiAccountBalanceChecker = val; | ||
| state.isMultiAccountBalancesEnabled = val; |
Contributor
Author
There was a problem hiding this comment.
Making sure isMultiAccountBalancesEnabled gets updated as well. Before this, it was always kept as true and not being used at all.
Contributor
Author
|
@MetaMask/policy-reviewers Changes related to the removal of |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [f87fae0]
UI Startup Metrics (1256 ± 87 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
bergarces
commented
Oct 31, 2025
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [ba0182f]
UI Startup Metrics (1315 ± 105 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [3cfb04e]
UI Startup Metrics (1258 ± 101 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
bergarces
changed the title
Prithpal-Sooriya
approved these changes
Oct 31, 2025
OGPoyraz
approved these changes
Oct 31, 2025
ffmcgee725
approved these changes
Oct 31, 2025
ccharly
approved these changes
Oct 31, 2025
Contributor
ccharly
left a comment
ccharly
left a comment
There was a problem hiding this comment.
LGTM for accounts files (assuming this is valid, but I'll let @seaona confirm that 😁)
seaona
approved these changes
Oct 31, 2025
Member
seaona
left a comment
seaona
left a comment
There was a problem hiding this comment.
Overall changes make sense. I added a couple of nits. Given this is a big PR with lots of code owners, it's not 100% blocking, but it would be good to have a follow-up PR addressing the changes, if this makes sense @bergarces
| recipientAddress: DEFAULT_FIXTURE_ACCOUNT, | ||
| amount: '1', | ||
| }); | ||
| await driver.waitForSelector('.transaction-status-label--confirmed'); |
Member
There was a problem hiding this comment.
small nit but we shouldn't include selectors in the spec files, rather move them in page objects. This helps maintainability and scalability of our e2e suite
| amount: '1', | ||
| isSyncFlow: false, | ||
| }); | ||
| await driver.waitForSelector('.transaction-status-label--confirmed'); |
Member
There was a problem hiding this comment.
same as above: no selectors in spec files
| // Balance is 0 because aggregated balance has changed and doesn't display dev networks | ||
| // The method should be udpdated to use the new selector and we can then remove checkExpectedTokenBalanceIsDisplayed | ||
| await loginWithBalanceValidation(driver, undefined, undefined, '0'); | ||
| await loginWithBalanceValidation(driver); |
Member
There was a problem hiding this comment.
thanks for the comment, it makes sense to me
SteP-n-s
approved these changes
Oct 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR concludes the migration to
AccountsTrackerControllerfrom core. This is necessary in order to benefit from performance changes added and planned to the core controller.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-1368
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces the local AccountTrackerController with the core one, removes legacy tracker/polling and gas-limit state, and updates state shape, selectors, metrics, tests, and dependencies accordingly.
AccountTrackerControllerwith@metamask/assets-controllersversion; update init, messengers, allowed actions/events, and wiring.account-tracker-controller*,batch-utils*,constants/contracts.ts, types) and related listeners/APIs (e.g., balance-update on tx, account syncing).accountsandcurrentBlockGasLimit*from background/UI state; rely onaccountsByChainIdonly; update sentry state and types.@metamask/assets-controllersto^86.0.0; update LavaMoat policies.isMultiAccountBalancesEnabledmirroringuseMultiAccountBalanceChecker.getBalanceand metrics.accountsByChainIdaddress handling (lowercasing in selectors); removegetBlockGasLimitusage; adjust gas estimate logic.token-searchnull guard; update tests/fixtures to checksummed addresses.number_of_accountsfromaccountsByChainId; update masked/removed fields.Written by Cursor Bugbot for commit 3cfb04e. This will update automatically on new commits. Configure here.