-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: defer UI actions until swap quotes are fully loaded #37336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (7 files, +102 -24)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [cf52a62]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [cfc4177]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f77d05e]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [cc72852]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [d02a1a7]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1de7544]
UI Startup Metrics (1192 ± 89 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
1de7544 to
615a5bb
Compare
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c1b913a]
UI Startup Metrics (1268 ± 84 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [a8779fc]
UI Startup Metrics (1287 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [3b3ea00]
UI Startup Metrics (1311 ± 92 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
3b3ea00 to
6b56a74
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [6ac296b]
UI Startup Metrics (1253 ± 75 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0bbcbf1]
UI Startup Metrics (1283 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [56d13db]
UI Startup Metrics (1256 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [a74b6de]
UI Startup Metrics (1250 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Prevents jumpy UI updates when quotes are being streamed
Changelog
CHANGELOG entry: fix: defer UI actions until swap SSE quotes are fully loaded
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3027
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Disables submit and warning auto-scroll while quotes load, tweaks countdown display, switches analytics to use isTxSubmittable, removes an unused NetworkController action, and bumps bridge-controller to ^56.0.3.
BridgeCTAButtonnow disabled duringisLoading; adds tests (including parametric cases) and snapshots updated.prepare-bridge-pageavoids scrolling to warning banners while quotes are loading.useCountdownTimerinitializes withrefreshRate + STEPand offsets bySTEP(snapshots show 0:31/0:06).useQuoteFetchEventsusesuseIsTxSubmittableforcan_submitand keeps other quote metrics.NetworkController:getStatefromAllowedActionsand delegated actions inbridge-controller-messenger.@metamask/bridge-controllerto^56.0.3(lockfile updated).Written by Cursor Bugbot for commit a74b6de. This will update automatically on new commits. Configure here.