Skip to content

Conversation

@jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Oct 30, 2025

Description

Currently the main.yml workflow only runs once per combination of workflow and branch.

Usually if a new commit is pushed to a branch, the CI run on the previous commit is no longer relevant. However that's not true on main. Getting a full CI run for every commit on main is critical for investigating CI failures that somehow make their way to main (e.g. flaky test failures).

The concurrency group ID has been updated to use the SHA as the ID on just the main branch, ensuring new commits don't cancel CI workflows for previous commits.

Based on mobile one: MetaMask/metamask-mobile#21893

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Update GitHub Actions concurrency group to use commit SHA on main, enabling concurrent CI runs per commit on the main branch.

Written by Cursor Bugbot for commit 0ed9612. This will update automatically on new commits. Configure here.

@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 30, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Oct 30, 2025
@jvbriones jvbriones enabled auto-merge October 30, 2025 17:20
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 0ed9612 | Date: 10/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 970ms (±42ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 674ms (±38ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 970ms 42ms 938ms 1.25s 994ms 1.25s
domContentLoaded 674ms 38ms 654ms 939ms 686ms 939ms
firstPaint 74ms 13ms 60ms 176ms 88ms 176ms
firstContentfulPaint 74ms 13ms 60ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [0ed9612]
UI Startup Metrics (1301 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13011123153910113621481
load111695513359411721290
domContentLoaded111094913319311671282
domInteractive20146791943
firstPaint58179130444510881244
backgroundConnect2342172799238257
firstReactRender28194863242
getState23980112837
initialActions60356722
loadScripts8837031107929401053
setupStore1262541321
numNetworkReqs96327630
BrowserifyPower User HomeuiStartup23041798449375930814493
load1177931209934616182099
domContentLoaded1166925205433816012054
domInteractive291678194978
firstPaint883230209449610522094
backgroundConnect26022247360281473
firstReactRender25212722627
getState20215848979195489
initialActions519269
loadScripts916710160729013291607
setupStore1394481244
numNetworkReqs379187714185644714
WebpackStandard HomeuiStartup8557331087718831006
load63859190763647799
domContentLoaded63158589462641789
domInteractive16124481441
firstPaint17058840153181600
backgroundConnect23127592641
firstReactRender2817116133239
getState1263041418
initialActions3113247
loadScripts62858388260638779
setupStore1062231216
numNetworkReqs106378832
WebpackPower User HomeuiStartup17531289277447722522774
load77664112902168801290
domContentLoaded72863010981578521098
domInteractive211380173080
firstPaint5118111023538581102
backgroundConnect14020561185200561
firstReactRender28236192761
getState14811216415159164
initialActions111138334138
loadScripts72362810861538421086
setupStore2261934515193
numNetworkReqs365201697174578697
FirefoxBrowserifyStandard HomeuiStartup1443123417988414951580
load1235107514267012791373
domContentLoaded1234107514257012791373
domInteractive1143331046118225
firstPaint------
backgroundConnect4224135164772
firstReactRender25214552641
getState74193712
initialActions327136
loadScripts1210105713956812561326
setupStore1062431115
numNetworkReqs96326727
BrowserifyPower User HomeuiStartup26662172414054329344140
load14411226199519815371995
domContentLoaded14401225199419815371994
domInteractive17686568115230568
firstPaint------
backgroundConnect2523115853803151585
firstReactRender422782184782
getState1216718834159188
initialActions13289231089
loadScripts13651156171714914951717
setupStore3661133550113
numNetworkReqs270134569106329569
WebpackStandard HomeuiStartup16531470213912616971980
load1408124617569114581566
domContentLoaded1408124617569114571565
domInteractive1053341954111203
firstPaint------
backgroundConnect4927151225589
firstReactRender332479133373
getState104180181023
initialActions41183413
loadScripts1379122817328814331501
setupStore177217251439
numNetworkReqs96347729
WebpackPower User HomeuiStartup27042194347436730393474
load15711234200220117372002
domContentLoaded15701234200220117362002
domInteractive1215620839162208
firstPaint------
backgroundConnect16533575143256575
firstReactRender40315674656
getState13110317021152170
initialActions721751217
loadScripts15261216192019016841920
setupStore25965153765
numNetworkReqs272134534110359534
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 68 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

Copy link
Member

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jvbriones jvbriones added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit 30453d2 Oct 31, 2025
346 of 351 checks passed
@jvbriones jvbriones deleted the ci-concurrency-group branch October 31, 2025 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.9.0 Issue or pull request that will be included in release 13.9.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants