Skip to content

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Oct 31, 2025

Description

Fix token name truncation

Long term, we need to handle this in a list item type of component

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: token name truncation

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

BEFORE truncate fix

After

AFTER truncate fix

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds min-w-0 to token title wrappers to allow proper name ellipsis; updates affected snapshots.

  • Frontend
    • ui/components/app/assets/token-cell/cells/token-cell-title.tsx: Add className="min-w-0" to the outer and inner Box wrappers around AssetCellTitle/Tag to enable token name truncation.
  • Tests
    • Update snapshots reflecting layout changes in:
      • ui/components/app/assets/token-cell/__snapshots__/token-cell.test.tsx.snap
      • ui/pages/asset/components/__snapshots__/asset-page.test.tsx.snap
      • ui/pages/defi/components/__snapshots__/defi-details-list.test.tsx.snap
      • ui/pages/defi/components/__snapshots__/defi-details-page.test.tsx.snap

Written by Cursor Bugbot for commit db41a4d. This will update automatically on new commits. Configure here.

@n3ps n3ps requested a review from a team as a code owner October 31, 2025 14:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Oct 31, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 31, 2025

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (2 files, +4 -4)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 assets/
          • 📁 token-cell/
            • 📁 __snapshots__/
              • 📄 token-cell.test.tsx.snap +2 -2
            • 📁 cells/
              • 📄 token-cell-title.tsx +2 -2

@n3ps n3ps enabled auto-merge October 31, 2025 14:40
NidhiKJha
NidhiKJha previously approved these changes Oct 31, 2025
@n3ps n3ps dismissed stale reviews from NidhiKJha and Prithpal-Sooriya via db41a4d October 31, 2025 14:49
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: db41a4d | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±63ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 81ms (±43ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 42ms 1.02s 1.36s 1.07s 1.36s
domContentLoaded 729ms 63ms 701ms 1.31s 753ms 1.31s
firstPaint 81ms 43ms 64ms 508ms 88ms 508ms
firstContentfulPaint 81ms 43ms 64ms 508ms 88ms 508ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [db41a4d]
UI Startup Metrics (1225 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12251044160210012911380
load104189113899110961192
domContentLoaded103488613768910901185
domInteractive201272101846
firstPaint68583139742110711189
backgroundConnect2001812218205218
firstReactRender28165573241
getState23876122745
initialActions90519934
loadScripts841703118989893992
setupStore1152641421
numNetworkReqs96327631
BrowserifyPower User HomeuiStartup23011921332252429143322
load1221966188334517631883
domContentLoaded1212956186534317561865
domInteractive331694235494
firstPaint69692121938810211219
backgroundConnect26822844057270440
firstReactRender27243223032
getState19016126630205266
initialActions113106257106
loadScripts959730149230414631492
setupStore11101311313
numNetworkReqs325178668179518668
WebpackStandard HomeuiStartup8747431202818861073
load65260299977656885
domContentLoaded64459498976650877
domInteractive15124061535
firstPaint20359948213198752
backgroundConnect24125582839
firstReactRender291889113339
getState1262141518
initialActions3017247
loadScripts64059197874648866
setupStore1162331216
numNetworkReqs96368832
WebpackPower User HomeuiStartup17131287240437122182404
load75162011621669011162
domContentLoaded71360910061258201006
domInteractive211351113251
firstPaint5307011253408261125
backgroundConnect12319453144116453
firstReactRender27224042740
getState16013020216161202
initialActions2011594227159
loadScripts709607996122808996
setupStore22789243189
numNetworkReqs289120558150500558
FirefoxBrowserifyStandard HomeuiStartup1454128217419615101613
load1239111314087412981368
domContentLoaded1239111314087412981368
domInteractive1153427246129241
firstPaint------
backgroundConnect4224134194582
firstReactRender26217082649
getState8418518711
initialActions3110135
loadScripts1212109713777312691342
setupStore1063231113
numNetworkReqs96336726
BrowserifyPower User HomeuiStartup25682183380839127253808
load14011167174314414931743
domContentLoaded14001167174314414931743
domInteractive1749835580268355
firstPaint------
backgroundConnect18831649170245649
firstReactRender36285994559
getState1185019934136199
initialActions716014760
loadScripts13411144162312914401623
setupStore3271333334133
numNetworkReqs241150546105319546
WebpackStandard HomeuiStartup16811460210313417092031
load1436126917989814811618
domContentLoaded1436126917989814811617
domInteractive1203452482123341
firstPaint------
backgroundConnect5028129205690
firstReactRender342479163077
getState12417224948
initialActions4176949
loadScripts1407124817629414441582
setupStore1273441319
numNetworkReqs96337828
WebpackPower User HomeuiStartup29472382427550331714275
load16841350227227619142272
domContentLoaded16831350227127519142271
domInteractive1607935281197352
firstPaint------
backgroundConnect18652630173196630
firstReactRender46291061949106
getState1459429748161297
initialActions1012682026
loadScripts16211323219125318022191
setupStore36792296492
numNetworkReqs282160584133333584
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 68 Bytes (0%)
  • ui: 40 Bytes (0%)
  • common: 10 Bytes (0%)

@n3ps n3ps added this pull request to the merge queue Oct 31, 2025
auto-merge was automatically disabled October 31, 2025 16:29

Pull Request is not mergeable

Merged via the queue into main with commit d27843e Oct 31, 2025
329 of 331 checks passed
@n3ps n3ps deleted the n3ps/fix-token-truncate branch October 31, 2025 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.9.0 Issue or pull request that will be included in release 13.9.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants