-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: token name truncation #37429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: token name truncation #37429
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨💎 @MetaMask/metamask-assets (2 files, +4 -4)
|
Prithpal-Sooriya
previously approved these changes
Oct 31, 2025
NidhiKJha
previously approved these changes
Oct 31, 2025
sahar-fehri
approved these changes
Oct 31, 2025
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [db41a4d]
UI Startup Metrics (1225 ± 100 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
salimtb
approved these changes
Oct 31, 2025
auto-merge was automatically disabled
October 31, 2025 16:29
Pull Request is not mergeable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.9.0
Issue or pull request that will be included in release 13.9.0
size-XS
team-core-extension-ux
Core Extension UX team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix token name truncation
Long term, we need to handle this in a list item type of component
Changelog
CHANGELOG entry: fix: token name truncation
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds
min-w-0to token title wrappers to allow proper name ellipsis; updates affected snapshots.ui/components/app/assets/token-cell/cells/token-cell-title.tsx: AddclassName="min-w-0"to the outer and innerBoxwrappers aroundAssetCellTitle/Tagto enable token name truncation.ui/components/app/assets/token-cell/__snapshots__/token-cell.test.tsx.snapui/pages/asset/components/__snapshots__/asset-page.test.tsx.snapui/pages/defi/components/__snapshots__/defi-details-list.test.tsx.snapui/pages/defi/components/__snapshots__/defi-details-page.test.tsx.snapWritten by Cursor Bugbot for commit db41a4d. This will update automatically on new commits. Configure here.