feat: gas sponsorship for Shield Trial Subscriptions #37441
Merged
+420
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +12 -0)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [4e6490f]
UI Startup Metrics (1259 ± 104 ms)
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [506b247]
|
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [2046f20]
UI Startup Metrics (1293 ± 81 ms)
|
lwin-kyaw
commented
Nov 3, 2025
lwin-kyaw
commented
Nov 3, 2025
lwin-kyaw
commented
Nov 3, 2025
lwin-kyaw
commented
Nov 3, 2025
lwin-kyaw
commented
Nov 3, 2025
lwin-kyaw
commented
Nov 3, 2025
tuna1207
approved these changes
Nov 3, 2025
tuna1207
requested changes
Nov 3, 2025
app/scripts/controller-init/confirmations/transaction-controller-init.ts
Outdated
Show resolved
Hide resolved
tanguyenvn
reviewed
Nov 3, 2025
app/scripts/controller-init/confirmations/transaction-controller-init.ts
Outdated
Show resolved
Hide resolved
Collaborator
Builds ready [a0b9a71]
UI Startup Metrics (1212 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
previously approved these changes
Nov 5, 2025
tuna1207
previously approved these changes
Nov 6, 2025
Collaborator
Builds ready [9ad8175]
UI Startup Metrics (1242 ± 91 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
previously approved these changes
Nov 6, 2025
lwin-kyaw
dismissed stale reviews from chaitanyapotti and tuna1207
via
f3e0f65
Collaborator
Builds ready [f3e0f65]
UI Startup Metrics (1246 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
approved these changes
Nov 7, 2025
tuna1207
approved these changes
Nov 11, 2025
vinistevam
approved these changes
Nov 11, 2025
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
metamaskbot
added
the
release-13.10.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR submits gas sponsorship intents for shield trial subscriptions.
Changelog
CHANGELOG entry: added gas sponsorship for shield trial subscriptions
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a SubscriptionService hook to submit Shield sponsorship intents on approve transactions, wires required messengers, computes sponsorship at publish, and adds tests; bumps shield-controller.
SubscriptionService:submitSubscriptionSponsorshipIntenthandler to submitPRODUCT_TYPES.SHIELDsponsorship intents forTransactionType.shieldSubscriptionApprove.isSponsoredin_onShieldSubscriptionApprovalTransactionusingtransactionMeta.isGasFeeSponsoredandisSendBundleSupported.TransactionControllerInitaddhooks.afterAdd.updateTransactionto callSubscriptionService:submitSubscriptionSponsorshipIntentbefore state add.SubscriptionController:submitSponsorshipIntents,TransactionController:getTransactions, and various*Controller:getStateto SubscriptionService messenger.SubscriptionServiceActionin TransactionController init messenger.@metamask/shield-controllerto^1.2.0.Written by Cursor Bugbot for commit f3e0f65. This will update automatically on new commits. Configure here.