fix: flaky tests Preinstalled example Snap...

[seaona]

Description

It seems ci conditions got worse in the last week, surfacing more flakiness in different points.
This spec fails because it waits for events with a given delay but it's not enough now. Increasing the delay fixes the issue.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Replaces largeDelayMs with a fixed 5000ms wait in Sentry/Segment tests to reduce flakiness.

• Tests (e2e):
  • In test/e2e/flask/snaps/preinstalled-example.spec.ts:
    • Replace largeDelayMs with 5000 for driver.wait when awaiting mocked endpoints in:
      • snap_trackError (Sentry error)
      • snap_trackEvent (Segment event)
      • snap_startTrace/snap_endTrace (Sentry trace)
    • Simplify helpers import (remove unused largeDelayMs).

^{Written by Cursor Bugbot for commit 5bbc0b9. This will update automatically on new commits. Configure here.}

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +4 -9)

• 📁 test/
  • 📁 e2e/
    • 📁 flask/
      • 📁 snaps/
        • 📄 preinstalled-example.spec.ts +4 -9

[metamaskbot]

Builds ready [5bbc0b9]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1267 ± 98 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1267	1128	1654	98	1332	1443
			load	1082	950	1391	90	1149	1244
			domContentLoaded	1077	947	1386	88	1144	1233
			domInteractive	22	14	117	16	20	52
			firstPaint	663	87	1406	453	1099	1216
			backgroundConnect	232	217	255	8	236	249
			firstReactRender	31	18	49	8	38	45
			getState	23	11	73	10	26	42
			initialActions	7	1	52	8	8	20
			loadScripts	851	707	1161	88	919	1005
			setupStore	11	6	27	4	11	19
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	2087	1800	3121	394	2567	3121
			load	1090	905	1775	257	1394	1775
			domContentLoaded	1078	900	1767	257	1385	1767
			domInteractive	28	16	78	18	43	78
			firstPaint	741	192	1472	459	1000	1472
			backgroundConnect	214	191	241	14	223	241
			firstReactRender	29	25	35	3	30	35
			getState	204	171	266	29	218	266
			initialActions	4	2	12	2	5	12
			loadScripts	881	712	1558	247	1172	1558
			setupStore	15	8	32	8	24	32
			numNetworkReqs	199	101	348	97	311	348
	Webpack	Standard Home	uiStartup	880	746	1250	101	891	1194
			load	655	593	1036	92	650	924
			domContentLoaded	645	587	990	86	643	909
			domInteractive	16	12	55	8	14	37
			firstPaint	232	56	1036	249	203	917
			backgroundConnect	27	13	105	17	27	73
			firstReactRender	29	17	50	7	34	36
			getState	13	5	23	3	15	18
			initialActions	3	1	18	3	5	8
			loadScripts	642	585	979	84	641	899
			setupStore	11	6	21	3	12	16
			numNetworkReqs	13	6	76	19	8	71
	Webpack	Power User Home	uiStartup	1416	1220	1924	257	1726	1924
			load	730	626	1167	153	839	1167
			domContentLoaded	698	614	1026	120	821	1026
			domInteractive	28	13	96	27	29	96
			firstPaint	347	70	888	251	634	888
			backgroundConnect	68	20	213	63	142	213
			firstReactRender	27	26	30	1	28	30
			getState	157	113	197	23	169	197
			initialActions	5	1	32	8	8	32
			loadScripts	694	612	1016	117	809	1016
			setupStore	13	6	30	8	20	30
			numNetworkReqs	154	99	283	68	202	283
Firefox	Browserify	Standard Home	uiStartup	1546	1272	2109	136	1598	1786
			load	1304	1107	1526	80	1369	1446
			domContentLoaded	1304	1107	1525	80	1369	1446
			domInteractive	120	34	337	51	132	226
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	26	218	26	53	84
			firstReactRender	27	22	53	6	28	40
			getState	11	4	197	21	9	28
			initialActions	6	2	93	11	4	14
			loadScripts	1275	1090	1440	76	1335	1403
			setupStore	16	7	191	21	14	31
			numNetworkReqs	13	6	66	17	7	61
	Browserify	Power User Home	uiStartup	2714	2357	3692	408	3028	3692
			load	1509	1260	2019	237	1758	2019
			domContentLoaded	1509	1260	2018	237	1758	2018
			domInteractive	235	99	566	189	548	566
			firstPaint	-	-	-	-	-	-
			backgroundConnect	132	34	444	122	262	444
			firstReactRender	44	33	60	8	51	60
			getState	151	103	295	46	181	295
			initialActions	13	2	76	19	16	76
			loadScripts	1468	1213	1985	235	1710	1985
			setupStore	45	10	269	62	56	269
			numNetworkReqs	136	66	338	77	194	338
	Webpack	Standard Home	uiStartup	1633	1446	2200	181	1652	2147
			load	1382	1231	1673	100	1421	1593
			domContentLoaded	1382	1230	1673	100	1421	1592
			domInteractive	103	40	286	39	112	175
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	27	219	33	54	126
			firstReactRender	35	22	80	16	34	76
			getState	8	4	42	5	8	16
			initialActions	11	1	190	36	3	24
			loadScripts	1352	1208	1620	90	1392	1545
			setupStore	16	7	237	25	12	43
			numNetworkReqs	12	6	67	16	7	60
	Webpack	Power User Home	uiStartup	2650	2220	4186	481	2838	4186
			load	1509	1261	1868	184	1662	1868
			domContentLoaded	1508	1261	1867	185	1662	1867
			domInteractive	173	66	488	132	304	488
			firstPaint	-	-	-	-	-	-
			backgroundConnect	106	31	362	97	99	362
			firstReactRender	46	33	64	10	55	64
			getState	155	97	241	44	196	241
			initialActions	20	1	160	42	12	160
			loadScripts	1472	1239	1821	177	1623	1821
			setupStore	31	8	113	30	45	113
			numNetworkReqs	148	65	345	90	219	345

📊 Page Load Benchmark Results

Current Commit: 5bbc0b9 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.06s (±54ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
• domContentLoaded-> current mean value: 738ms (±51ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	54ms	1.02s	1.34s	1.11s	1.34s
domContentLoaded	738ms	51ms	709ms	1.02s	777ms	1.02s
firstPaint	78ms	10ms	64ms	152ms	84ms	152ms
firstContentfulPaint	78ms	10ms	64ms	152ms	84ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 68 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 10 Bytes (0%)