-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: fixed User Login Cancelled Error for firefox cp-13.9.0 #37658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+37
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (1 files, +6 -6)
|
Collaborator
Builds ready [f3ff026]
UI Startup Metrics (1211 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
tuna1207
approved these changes
Nov 10, 2025
chaitanyapotti
approved these changes
Nov 10, 2025
Collaborator
|
More than one release label on PR. Keeping the lowest one (release-13.9.0) on PR and removing other release labels (release-13.10.0). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.9.0
Issue or pull request that will be included in release 13.9.0
seedless-onboarding
Any issues related to the seedless onboarding feature
size-S
team-onboarding
Onboarding team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: null
Related issues
Fixes: #37645
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds cross-browser detection of user-cancelled OAuth login (including Firefox) and updates flows to treat it as a non-error.
OAuthErrorMessages.USER_CANCELLED_LOGIN_ERROR_FIREFOX.isUserCancelledLoginError(error)helper for cross-browser detection.app/scripts/services/oauth/oauth-service.ts):#isUserCancelledLoginError()with#getUserCancelledLoginError()returning the actualErrorwhen cancel is detected viacheckForLastError()andisUserCancelledLoginError.responseUrl, reject with user-cancelled error if present; otherwise default toOAuthErrorMessages.NO_REDIRECT_URL_FOUND_ERROR.ui/pages/onboarding-flow/welcome/welcome.js):isUserCancelledLoginErrorin login error handlers to suppress UI errors when the user cancels.Written by Cursor Bugbot for commit f3ff026. This will update automatically on new commits. Configure here.