Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Nov 12, 2025

Description

Updates bitcoin to 1.5.0, which places accounts info under encrypted
state

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Upgrade @metamask/bitcoin-wallet-snap from 1.4.5 to 1.5.0 with corresponding yarn.lock and attribution updates.

  • Dependencies:
    • Upgrade @metamask/bitcoin-wallet-snap to ^1.5.0 in package.json.
    • Update yarn.lock to resolve @metamask/bitcoin-wallet-snap@1.5.0.
    • Refresh attribution.txt to reflect version 1.5.0.

Written by Cursor Bugbot for commit 8c006ec. This will update automatically on new commits. Configure here.

de21015

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

Updates bitcoin to `1.5.0`, which places accounts info under encrypted
state

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37756?quickstart=1)

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Update dependency `@metamask/bitcoin-wallet-snap` from `1.4.5` to
`1.5.0`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e3002b9. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 12, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​bitcoin-wallet-snap@​1.4.5 ⏵ 1.5.01001008397 +1100

View full report

@metamaskbot
Copy link
Collaborator

Builds ready [8c006ec]
UI Startup Metrics (1146 ± 94 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup114699216269411841291
load98185313838410291124
domContentLoaded97584813698210181115
domInteractive201377121751
firstPaint70015813763739971076
backgroundConnect1891762248192204
firstReactRender22176662330
getState19584112339
initialActions001001
loadScripts792667115681840939
setupStore1062931013
numNetworkReqs1367620674
BrowserifyPower User HomeuiStartup18871576233620019942336
load1049908146916712381469
domContentLoaded1038901146016812321460
domInteractive291669195469
firstPaint47918810353279421035
backgroundConnect24522327216258272
firstReactRender332575123975
getState17915324024186240
initialActions001011
loadScripts809676121116310081211
setupStore1593682236
numNetworkReqs1666737594274375
WebpackStandard HomeuiStartup823695132587832981
load601552106471599752
domContentLoaded594547103467591741
domInteractive1611107131338
firstPaint17257792143194568
backgroundConnect251286142956
firstReactRender29185483438
getState1163241218
initialActions001001
loadScripts591545102465589730
setupStore1153141218
numNetworkReqs1367419871
WebpackPower User HomeuiStartup1123887160517111401605
load57651682888657828
domContentLoaded55350577971603779
domInteractive221274173374
firstPaint30053784245518784
backgroundConnect631624674156246
firstReactRender25222612526
getState1228014624135146
initialActions001001
loadScripts55050477169595771
setupStore952341023
numNetworkReqs1286321952175219
FirefoxBrowserifyStandard HomeuiStartup15161325201013715851796
load1285114015459513521461
domContentLoaded1285114015459513521461
domInteractive1073535751108200
firstPaint------
backgroundConnect48241752755118
firstReactRender26227472738
getState10420121716
initialActions002001
loadScripts1257112315089013271422
setupStore158228221329
numNetworkReqs1266215760
BrowserifyPower User HomeuiStartup23192055277222725692772
load13491111180522115871805
domContentLoaded13491110180522115871805
domInteractive17575519146335519
firstPaint------
backgroundConnect983230173140301
firstReactRender433174104774
getState1055516021114160
initialActions001011
loadScripts13161090175321215451753
setupStore31674204674
numNetworkReqs1836836583256365
WebpackStandard HomeuiStartup15431391211114215501893
load1318118316259813331570
domContentLoaded1318118216259813331570
domInteractive903129035105146
firstPaint------
backgroundConnect4422243274888
firstReactRender27216872736
getState11419826743
initialActions002011
loadScripts1291116315979013061501
setupStore14792141345
numNetworkReqs1367418767
WebpackPower User HomeuiStartup25292211344233427463442
load15161280188619817531886
domContentLoaded15151279188519817521885
domInteractive16967538153280538
firstPaint------
backgroundConnect12731470117199470
firstReactRender41306195061
getState1127324436116244
initialActions001011
loadScripts14751252184319217241843
setupStore29681255281
numNetworkReqs1696131471221314
📊 Page Load Benchmark Results

Current Commit: 8c006ec | Date: 11/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±63ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±61ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 63ms 1.02s 1.33s 1.26s 1.33s
domContentLoaded 737ms 61ms 708ms 1.01s 939ms 1.01s
firstPaint 78ms 11ms 60ms 172ms 88ms 172ms
firstContentfulPaint 78ms 11ms 60ms 172ms 88ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@gauthierpetetin gauthierpetetin merged commit 4a75df2 into release/13.9.0 Nov 12, 2025
168 of 169 checks passed
@gauthierpetetin gauthierpetetin deleted the cherry-pick-13-9-0-de21015 branch November 12, 2025 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 12, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-13.9.0 on PR, as PR was cherry-picked in branch 13.9.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.9.0 Issue or pull request that will be included in release 13.9.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants