fix: edit account circular dependency

[n3ps]

Description

Fix the edit-account-modal circular dependency

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Removes a circular dependency by updating AccountListItem import in edit-accounts-modal and reflecting the change in development/circular-deps.jsonc.

• Circular dependencies:
  • Removed cycle involving ui/components/multichain/edit-accounts-modal/* from development/circular-deps.jsonc.
• Multichain UI:
  • ui/components/multichain/edit-accounts-modal/edit-accounts-modal.tsx: Update AccountListItem import from .. to ../account-list-item to break the cycle.

^{Written by Cursor Bugbot for commit 77c4c44. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -1)

• 📁 ui/
  • 📁 components/
    • 📁 multichain/
      • 📁 edit-accounts-modal/
        • 📄 edit-accounts-modal.tsx +1 -1

---

🔒 @MetaMask/extension-security-team (1 files, +0 -5)

• 📁 development/
  • 📄 circular-deps.jsonc +0 -5

---

👨‍🔧 @dbrans (1 files, +0 -5)

• 📁 development/
  • 📄 circular-deps.jsonc +0 -5

---

👨‍🔧 @HowardBraham (1 files, +0 -5)

• 📁 development/
  • 📄 circular-deps.jsonc +0 -5

[metamaskbot]

Builds ready [77c4c44]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1221 ± 84 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1221	1072	1475	84	1289	1358
			load	1056	932	1207	78	1116	1189
			domContentLoaded	1050	927	1198	77	1111	1182
			domInteractive	22	14	86	16	17	67
			firstPaint	626	145	1215	421	1064	1187
			backgroundConnect	231	216	264	8	234	248
			firstReactRender	24	18	120	11	25	31
			getState	20	7	63	9	24	36
			initialActions	0	0	1	0	0	1
			loadScripts	825	697	968	76	893	946
			setupStore	10	7	24	2	11	14
			numNetworkReqs	13	6	75	19	6	71
	Browserify	Power User Home	uiStartup	1758	1517	2982	359	1963	2982
			load	1082	930	1645	210	1300	1645
			domContentLoaded	1074	926	1617	206	1293	1617
			domInteractive	47	16	176	50	101	176
			firstPaint	700	118	1670	435	982	1670
			backgroundConnect	243	223	305	20	248	305
			firstReactRender	45	40	64	5	46	64
			getState	185	160	240	22	205	240
			initialActions	0	0	1	0	0	1
			loadScripts	841	703	1349	198	1071	1349
			setupStore	15	10	30	8	26	30
			numNetworkReqs	141	72	354	84	210	354
	Webpack	Standard Home	uiStartup	843	721	1235	104	835	1170
			load	623	568	1023	96	612	920
			domContentLoaded	616	564	1003	92	606	890
			domInteractive	17	12	56	11	15	48
			firstPaint	208	62	1010	210	206	876
			backgroundConnect	26	13	72	14	27	63
			firstReactRender	29	17	56	8	35	38
			getState	12	5	50	5	13	18
			initialActions	0	0	1	0	0	1
			loadScripts	613	562	993	90	604	880
			setupStore	13	6	51	7	13	28
			numNetworkReqs	13	6	77	19	8	71
	Webpack	Power User Home	uiStartup	1006	836	1643	264	1138	1643
			load	596	527	867	101	656	867
			domContentLoaded	581	520	825	89	641	825
			domInteractive	28	13	90	26	62	90
			firstPaint	367	56	868	287	645	868
			backgroundConnect	58	10	199	70	131	199
			firstReactRender	42	37	47	3	44	47
			getState	124	60	174	30	142	174
			initialActions	0	0	1	0	1	1
			loadScripts	578	518	817	86	634	817
			setupStore	14	6	26	9	25	26
			numNetworkReqs	120	72	231	55	167	231
Firefox	Browserify	Standard Home	uiStartup	1436	1262	1866	116	1459	1700
			load	1216	1090	1486	84	1248	1404
			domContentLoaded	1216	1090	1485	84	1248	1404
			domInteractive	99	33	324	47	104	220
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	26	131	18	50	78
			firstReactRender	26	21	52	6	26	42
			getState	11	7	44	5	11	17
			initialActions	0	0	1	0	0	1
			loadScripts	1191	1072	1434	77	1228	1364
			setupStore	14	7	207	21	12	32
			numNetworkReqs	12	6	70	16	7	58
	Browserify	Power User Home	uiStartup	2211	1806	2862	312	2564	2862
			load	1374	1168	1672	153	1518	1672
			domContentLoaded	1373	1167	1671	153	1517	1671
			domInteractive	195	64	536	181	491	536
			firstPaint	-	-	-	-	-	-
			backgroundConnect	112	23	322	81	154	322
			firstReactRender	64	51	92	12	74	92
			getState	120	94	178	24	136	178
			initialActions	1	0	1	1	1	1
			loadScripts	1342	1144	1638	151	1495	1638
			setupStore	37	5	142	41	57	142
			numNetworkReqs	146	72	235	60	203	235
	Webpack	Standard Home	uiStartup	1616	1442	2229	160	1642	1992
			load	1376	1222	1685	109	1419	1655
			domContentLoaded	1376	1222	1685	109	1419	1654
			domInteractive	98	31	396	55	102	188
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	25	241	34	51	135
			firstReactRender	33	25	101	13	32	77
			getState	12	8	58	7	11	20
			initialActions	0	0	2	0	0	1
			loadScripts	1348	1204	1618	98	1392	1585
			setupStore	16	7	109	18	12	68
			numNetworkReqs	13	6	69	17	7	66
	Webpack	Power User Home	uiStartup	2416	2002	3528	473	2734	3528
			load	1555	1301	2238	256	1766	2238
			domContentLoaded	1555	1301	2238	256	1765	2238
			domInteractive	191	39	801	204	265	801
			firstPaint	-	-	-	-	-	-
			backgroundConnect	111	34	330	91	164	330
			firstReactRender	74	53	113	15	86	113
			getState	147	70	281	56	188	281
			initialActions	1	0	6	1	1	6
			loadScripts	1521	1283	2203	252	1710	2203
			setupStore	30	7	103	28	50	103
			numNetworkReqs	145	57	334	103	250	334

📊 Page Load Benchmark Results

Current Commit: 77c4c44 | Date: 11/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.06s (±43ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
• domContentLoaded-> current mean value: 741ms (±61ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 91ms (±128ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	43ms	1.03s	1.41s	1.09s	1.41s
domContentLoaded	741ms	61ms	714ms	1.30s	755ms	1.30s
firstPaint	91ms	128ms	64ms	1.37s	88ms	1.37s
firstContentfulPaint	91ms	128ms	64ms	1.37s	88ms	1.37s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: 36 Bytes (0%)
• common: 20 Bytes (0%)

[HowardBraham]

Yay!

[MajorLift]

Nice