fix: UI issues in DAPP shield #37784
Merged
+143
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (11 files, +125 -31)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: UI Mismatch: MetaMask Swap vs. Market Rate
Removing the useEffect that syncs selectedSwapType with isQuotedSwap causes the UI to incorrectly display "Market rate" as selected when the transaction has already been updated to use the MetaMask quote. When a user selects MetaMask Swap and the transaction is updated with txParamsOriginal, the component will show the wrong button as selected if it remounts or the page refreshes, creating a mismatch between the actual transaction state and the displayed UI state.
ui/pages/confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx#L108-L113
...confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx
Show resolved
Hide resolved
Collaborator
Builds ready [40c0b7d]
UI Startup Metrics (1229 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…tamask-extension into dapp_shield_ui_fixes
Collaborator
Builds ready [72b8e2b]
UI Startup Metrics (1252 ± 84 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [d60faaf]
UI Startup Metrics (1183 ± 121 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Nov 14, 2025
vinistevam
approved these changes
Nov 14, 2025
metamaskbot
added
the
release-13.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI fixesin DAPP Shield functionlity.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6252
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6256
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces quote-swap simulation details with savings highlight and tooltip, updates the Dapp Swap banner to use Market rate, and hides origin/recipient rows for quoted swaps with corresponding i18n and tests.
QuoteSwapSimulationDetailsshowing outgoing/incoming balance changes and a highlighted "Get $X more" savings banner; includes header tooltip viabestQuoteTooltip.metamaskRatetomarketRate; remove auto-switch logic; wire selected quote to transaction update; minor styling import.OriginandRecipientrows, and batch approve simulation, for quoted swaps; add guard whentxParamsmissing.titleTooltip.bestQuoteTooltip,getDollarMore,marketRate; removemetamaskRatein en/en_GB.Written by Cursor Bugbot for commit d60faaf. This will update automatically on new commits. Configure here.