Skip to content

Conversation

@hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Nov 14, 2025

Description

Update Shield copy and error messages for consistency

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Standardizes Shield-related localization by using “MetaMask Transaction Shield,” lowercases the file uploader label, and refines plan detail wording in both en and en_GB.

  • i18n (en, en_GB):
    • Branding consistency: Replace Transaction Shield with MetaMask Transaction Shield across coverage alert messages (high risk, chain not supported, paused, potential risks, signature not supported, tx type not supported, unknown).
    • Copy tweaks:
      • Update shieldClaimFileUploader label to Image upload (casing).
      • Revise shieldTxDetails1Description to “Secures assets on covered transactions.”

Written by Cursor Bugbot for commit d29d69b. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hieu-w hieu-w self-assigned this Nov 14, 2025
@metamaskbot metamaskbot added the team-onboarding Onboarding team label Nov 14, 2025
@hieu-w hieu-w added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed area-shield labels Nov 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [d29d69b]
UI Startup Metrics (1258 ± 98 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1258109414879813221430
load109194712969011731248
domContentLoaded108594212888911681241
domInteractive2514104192179
firstPaint60999129944210851230
backgroundConnect2332202537237245
firstReactRender28207772940
getState22876112643
initialActions103112
loadScripts8587241055899381018
setupStore1062231118
numNetworkReqs1367620673
BrowserifyPower User HomeuiStartup22271932277223924872772
load1142947164124314781641
domContentLoaded1121928162024114621620
domInteractive622217254114172
firstPaint896272165343910451653
backgroundConnect22220424011234240
firstReactRender77451081993108
getState26019536750289367
initialActions104124
loadScripts919730140223512371402
setupStore311555124155
numNetworkReqs1249420237167202
WebpackStandard HomeuiStartup8547291227908551094
load62356694578619844
domContentLoaded61556192474612815
domInteractive191386141554
firstPaint19163899177205601
backgroundConnect251274132755
firstReactRender32207093741
getState1161831315
initialActions105111
loadScripts61255991372610805
setupStore1263541318
numNetworkReqs1367319671
WebpackPower User HomeuiStartup1089910165125813351651
load661577908121780908
domContentLoaded644571858109752858
domInteractive36121163978116
firstPaint38063862288600862
backgroundConnect631128482143284
firstReactRender39364224142
getState1409117024154170
initialActions101011
loadScripts640569848105741848
setupStore117277827
numNetworkReqs846413227129132
FirefoxBrowserifyStandard HomeuiStartup14961343215112515301732
load1261114614948013021441
domContentLoaded1261114614948013021440
domInteractive57331753656155
firstPaint------
backgroundConnect4126136164972
firstReactRender29235672948
getState1174461123
initialActions203123
loadScripts1236112714777812751405
setupStore1376491233
numNetworkReqs1266215755
BrowserifyPower User HomeuiStartup33002534458973142824589
load15371308210523618102105
domContentLoaded15371308210523618092105
domInteractive24574569168449569
firstPaint------
backgroundConnect6719215924089991592
firstReactRender79601381883138
getState19111238873242388
initialActions224134
loadScripts14821254188721317791887
setupStore67231853990185
numNetworkReqs1277823460226234
WebpackStandard HomeuiStartup16911507239615617152015
load14261261185311214621662
domContentLoaded14261259185211214621662
domInteractive56301642862126
firstPaint------
backgroundConnect53261812660115
firstReactRender34258993747
getState177162201354
initialActions203122
loadScripts13931241174110114251627
setupStore187197241462
numNetworkReqs1366916863
WebpackPower User HomeuiStartup35792865483068645194830
load17261502209020120032090
domContentLoaded17261502209020020022090
domInteractive25298557174512557
firstPaint------
backgroundConnect656141137841710091378
firstReactRender1026713119117131
getState18311932158215321
initialActions223023
loadScripts16791475204218919312042
setupStore15330618180189618
numNetworkReqs1246623256196232
📊 Page Load Benchmark Results

Current Commit: d29d69b | Date: 11/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±49ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±45ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±17ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 49ms 1.02s 1.42s 1.09s 1.42s
domContentLoaded 734ms 45ms 703ms 1.07s 762ms 1.07s
firstPaint 79ms 17ms 64ms 240ms 88ms 240ms
firstContentfulPaint 79ms 17ms 64ms 240ms 88ms 240ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 75 Bytes (0%)

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit c4a264b Nov 17, 2025
174 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/hieu/fix-copywright-and-error-message branch November 17, 2025 12:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
@metamaskbot metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-shield no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.11.0 Issue or pull request that will be included in release 13.11.0 size-S team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants