chore: add event for hide token #38358
Merged
+38
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [666c4df]
UI Startup Metrics (1275 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Nov 27, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| token_contract_address: token?.address, | ||
| token_decimal_precision: token?.decimals, | ||
| location: MetaMetricsEventLocation.TokenDetails, | ||
| token_standard: TokenStandard.ERC20, |
There was a problem hiding this comment.
Bug: Hardcoded ERC20 token standard ignores ERC721 tokens
The token_standard in the TokenHidden event is hardcoded as TokenStandard.ERC20, but the token object can also represent ERC721 tokens (it has an isERC721 property). When users hide an ERC721 token, the event will incorrectly report it as ERC20, causing inaccurate analytics data. The token standard could be determined dynamically using token?.isERC721 since TokenStandard.ERC721 is available in the same imported enum.
Collaborator
Builds ready [ff07f37]
UI Startup Metrics (1226 ± 125 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [247e105]
UI Startup Metrics (1144 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
salimtb
approved these changes
Nov 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Builds ready [11e465c]
UI Startup Metrics (1274 ± 109 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add event tracing for hiding tokens from asset options
Changelog
CHANGELOG entry: Adds event tracing for hide token.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds MetaMetrics tracking for hiding a token and updates
AssetOptionsto use atokenobject instead oftokenSymbol, adjusting call sites accordingly.ui/pages/asset/components/asset-options.js):MetaMetricsEventName.TokenHiddenon hide with token details (symbol,address,decimals,chain_id, etc.).tokenSymbolprop withtoken; update label to usetoken?.symboland validate viapropTypes.handleRemoveTokento wrap hide action; integrateMetaMetricsContextand related constants.ui/pages/asset/components/token-asset.tsx):tokentoAssetOptionsinstead oftokenSymbol.Written by Cursor Bugbot for commit 11e465c. This will update automatically on new commits. Configure here.