feat: enable spot-prices v3 #38393
Open
feat: enable spot-prices v3 #38393
+153
−372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +4 -9)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| statusCode: 200, | ||
| json: { | ||
| '0x0000000000000000000000000000000000000000': { | ||
| 'eip155:1/slip44:60': { |
There was a problem hiding this comment.
Bug: Hardcoded mainnet asset ID in price API mock
The spot prices mock is hardcoded to only respond to requests for eip155:1/slip44:60 (Ethereum mainnet), but tests run on various networks including localhost with chainId 1337. The chainId parameter passed to setupMocking is ignored, causing price API requests to fail for non-mainnet tests that don't provide a testSpecificMock. The mock should dynamically construct the asset ID based on the provided chainId parameter to support all test networks.
Collaborator
Builds ready [b288034]
UI Startup Metrics (1230 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [21bfcd8]
UI Startup Metrics (1206 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable spot prices v3 by removing patch forcing a fallback.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-1746
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Switches token price fetching to v3 using CAIP-19 asset IDs, updates all E2E/integration mocks and tests accordingly, adds
moncurrency, and lowercases account keys when storing token balances.v2/chains/{chainId}/spot-pricestov3/spot-priceswithassetIds(CAIP-19, e.g.,eip155:1/slip44:60,eip155:1/erc20:<addr>).assetIds,vsCurrency,includeMarketData).mockSpotPrices,mockEmptyPrices, etc.) to v3.TokenBalancesController: store balances under lowercasedaccountkeys.montoSUPPORTED_CURRENCIES.Written by Cursor Bugbot for commit 21bfcd8. This will update automatically on new commits. Configure here.