feat: fixes ssn submission bug

Author: georgeweiler

app/components/UI/Ramp/Deposit/Views/BasicInfo/BasicInfo.test.tsx

@@ -99,6 +99,7 @@ describe('BasicInfo Component', () => {
       screen.getByPlaceholderText('XXX-XX-XXXX'),
       '123456789',
     );
+    fireEvent.changeText(screen.getByTestId('ssn-input'), '123456789');
     expect(screen.toJSON()).toMatchSnapshot();
     fireEvent.press(screen.getByRole('button', { name: 'Continue' }));
 

app/components/UI/Ramp/Deposit/Views/BasicInfo/BasicInfo.tsx

@@ -135,16 +135,17 @@ const BasicInfo = (): JSX.Element => {
   );
 
   const handleFieldChange = useCallback(
-    (field: keyof BasicInfoFormData, nextAction?: () => void) => (value: string) => {
-      const currentValue = formData[field];
-      const isAutofill = value.length - currentValue.length > 1;
+    (field: keyof BasicInfoFormData, nextAction?: () => void) =>
+      (value: string) => {
+        const currentValue = formData[field];
+        const isAutofill = value.length - currentValue.length > 1;
 
-      handleFormDataChange(field)(value);
+        handleFormDataChange(field)(value);
 
-      if (isAutofill && nextAction) {
-        nextAction();
-      }
-    },
+        if (isAutofill && nextAction) {
+          nextAction();
+        }
+      },
     [formData, handleFormDataChange],
   );
 
@@ -166,7 +167,10 @@ const BasicInfo = (): JSX.Element => {
                 label={strings('deposit.basic_info.first_name')}
                 placeholder="John"
                 value={formData.firstName}
-                onChangeText={handleFieldChange('firstName', focusNextField(lastNameInputRef))}
+                onChangeText={handleFieldChange(
+                  'firstName',
+                  focusNextField(lastNameInputRef),
+                )}
                 error={errors.firstName}
                 returnKeyType="next"
                 testID="first-name-input"
@@ -182,7 +186,10 @@ const BasicInfo = (): JSX.Element => {
                 label={strings('deposit.basic_info.last_name')}
                 placeholder="Smith"
                 value={formData.lastName}
-                onChangeText={handleFieldChange('lastName', focusNextField(phoneInputRef))}
+                onChangeText={handleFieldChange(
+                  'lastName',
+                  focusNextField(phoneInputRef),
+                )}
                 error={errors.lastName}
                 returnKeyType="next"
                 testID="last-name-input"
@@ -198,7 +205,10 @@ const BasicInfo = (): JSX.Element => {
             <DepositPhoneField
               label={strings('deposit.basic_info.phone_number')}
               value={formData.mobileNumber}
-              onChangeText={handleFieldChange('mobileNumber', focusNextField(dateInputRef))}
+              onChangeText={handleFieldChange(
+                'mobileNumber',
+                focusNextField(dateInputRef),
+              )}
               error={errors.mobileNumber}
               ref={phoneInputRef}
               onSubmitEditing={focusNextField(dateInputRef)}
@@ -232,10 +242,7 @@ const BasicInfo = (): JSX.Element => {
                 label={strings('deposit.basic_info.social_security_number')}
                 placeholder="XXX-XX-XXXX"
                 value={formData.ssn}
-                onChangeText={handleFieldChange('ssn', () => {
-                  Keyboard.dismiss();
-                  handleOnPressContinue();
-                })}
+                onChangeText={handleFieldChange('ssn')}
                 error={errors.ssn}
                 returnKeyType="done"
                 testID="ssn-input"
@@ -247,7 +254,6 @@ const BasicInfo = (): JSX.Element => {
                 maxLength={11}
                 onSubmitEditing={() => {
                   Keyboard.dismiss();
-                  handleOnPressContinue();
                 }}
               />
             )}

app/components/UI/Ramp/Deposit/Views/BasicInfo/__snapshots__/BasicInfo.test.tsx.snap

@@ -1140,21 +1140,6 @@ exports[`BasicInfo Component navigates to address page when form is valid and co
                                       />
                                     </View>
                                   </View>
-                                  <Text
-                                    accessibilityRole="text"
-                                    style={
-                                      {
-                                        "color": "#ca3542",
-                                        "fontFamily": "Geist Regular",
-                                        "fontSize": 12,
-                                        "letterSpacing": 0,
-                                        "lineHeight": 24,
-                                        "marginTop": 4,
-                                      }
-                                    }
-                                  >
-                                    Social security number is required
-                                  </Text>
                                 </View>
                               </View>
                             </View>