Skip to content

Commit b13c860

Browse files
sethkfmansethkfman
committed
comments the fingerprint, repack, cache restore
1 parent 8b9607b commit b13c860

File tree

1 file changed

+92
-92
lines changed

1 file changed

+92
-92
lines changed

‎.github/workflows/build-android-e2e.yml‎

Lines changed: 92 additions & 92 deletions
Original file line numberDiff line numberDiff line change
@@ -72,52 +72,52 @@ jobs:
7272
echo "🚀 Setting up project..."
7373
yarn setup:github-ci --no-build-ios
7474
75-
# Generate fingerprint AFTER setup but BEFORE any build modifications (the fingerprint now is fake we do not want the cached apk)
76-
- name: Generate current fingerprint
77-
id: generate-fingerprint
78-
run: |
79-
FINGERPRINT=$(yarn fingerprint:generate)
80-
echo "fingerprint=$FINGERPRINT" >> "$GITHUB_OUTPUT"
81-
echo "Current fingerprint: ${FINGERPRINT}"
75+
# # Generate fingerprint AFTER setup but BEFORE any build modifications (the fingerprint now is fake we do not want the cached apk)
76+
# - name: Generate current fingerprint
77+
# id: generate-fingerprint
78+
# run: |
79+
# FINGERPRINT=$(yarn fingerprint:generate)
80+
# echo "fingerprint=$FINGERPRINT" >> "$GITHUB_OUTPUT"
81+
# echo "Current fingerprint: ${FINGERPRINT}"
8282

83-
- name: Determine target paths and Artifact Names
84-
id: determine-target-paths
85-
run: |
86-
if [[ "${{ inputs.build_type }}" == "flask" ]]; then
87-
{
88-
echo "apk-target-path=android/app/build/outputs/apk/flask/release"
89-
echo "test-apk-target-path=android/app/build/outputs/apk/androidTest/flask/release"
90-
echo "aab-target-path=android/app/build/outputs/bundle/flaskRelease"
91-
echo "artifact_name=app-flask-release"
92-
} >> "$GITHUB_OUTPUT"
93-
elif [[ "${{ inputs.build_type }}" == "main" ]]; then
94-
{
95-
echo "apk-target-path=android/app/build/outputs/apk/prod/release"
96-
echo "test-apk-target-path=android/app/build/outputs/apk/androidTest/prod/release"
97-
echo "aab-target-path=android/app/build/outputs/bundle/prodRelease"
98-
echo "artifact_name=app-prod-release"
99-
} >> "$GITHUB_OUTPUT"
100-
else
101-
echo "❌ Error: build_type ${{ inputs.build_type }} is not valid"
102-
exit 1
103-
fi
83+
# - name: Determine target paths and Artifact Names
84+
# id: determine-target-paths
85+
# run: |
86+
# if [[ "${{ inputs.build_type }}" == "flask" ]]; then
87+
# {
88+
# echo "apk-target-path=android/app/build/outputs/apk/flask/release"
89+
# echo "test-apk-target-path=android/app/build/outputs/apk/androidTest/flask/release"
90+
# echo "aab-target-path=android/app/build/outputs/bundle/flaskRelease"
91+
# echo "artifact_name=app-flask-release"
92+
# } >> "$GITHUB_OUTPUT"
93+
# elif [[ "${{ inputs.build_type }}" == "main" ]]; then
94+
# {
95+
# echo "apk-target-path=android/app/build/outputs/apk/prod/release"
96+
# echo "test-apk-target-path=android/app/build/outputs/apk/androidTest/prod/release"
97+
# echo "aab-target-path=android/app/build/outputs/bundle/prodRelease"
98+
# echo "artifact_name=app-prod-release"
99+
# } >> "$GITHUB_OUTPUT"
100+
# else
101+
# echo "❌ Error: build_type ${{ inputs.build_type }} is not valid"
102+
# exit 1
103+
# fi
104104

105-
- name: Check and restore cached APKs if Fingerprint is found
106-
id: apk-cache-restore
107-
uses: cirruslabs/cache@v4
108-
with:
109-
path: |
110-
${{ steps.determine-target-paths.outputs.apk-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}.apk
111-
${{ steps.determine-target-paths.outputs.test-apk-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}-androidTest.apk
112-
${{ steps.determine-target-paths.outputs.aab-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}.aab
113-
# Include Gradle properties in key to force rebuild when properties change
114-
# Keep the `hashFiles` call for Gradle config in-sync with these steps:
115-
# - "Cache Gradle dependencies"
116-
# - "Cache build artifacts"
117-
key: android-apk-${{ inputs.build_type }}-${{ env.CACHE_GENERATION }}-${{ steps.generate-fingerprint.outputs.fingerprint }}-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
118-
restore-keys: |
119-
android-apk-${{ inputs.build_type }}-${{ env.CACHE_GENERATION }}-
120-
android-apk-
105+
# - name: Check and restore cached APKs if Fingerprint is found
106+
# id: apk-cache-restore
107+
# uses: cirruslabs/cache@v4
108+
# with:
109+
# path: |
110+
# ${{ steps.determine-target-paths.outputs.apk-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}.apk
111+
# ${{ steps.determine-target-paths.outputs.test-apk-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}-androidTest.apk
112+
# ${{ steps.determine-target-paths.outputs.aab-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}.aab
113+
# # Include Gradle properties in key to force rebuild when properties change
114+
# # Keep the `hashFiles` call for Gradle config in-sync with these steps:
115+
# # - "Cache Gradle dependencies"
116+
# # - "Cache build artifacts"
117+
# key: android-apk-${{ inputs.build_type }}-${{ env.CACHE_GENERATION }}-${{ steps.generate-fingerprint.outputs.fingerprint }}-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
118+
# restore-keys: |
119+
# android-apk-${{ inputs.build_type }}-${{ env.CACHE_GENERATION }}-
120+
# android-apk-
121121

122122
- name: Cache Gradle dependencies
123123
uses: cirruslabs/cache@v4
@@ -183,54 +183,54 @@ jobs:
183183
GOOGLE_SERVICES_B64_ANDROID: ${{ secrets.GOOGLE_SERVICES_B64_ANDROID }}
184184
MM_INFURA_PROJECT_ID: ${{ secrets.MM_INFURA_PROJECT_ID }}
185185

186-
- name: Repack APK with JS updates using @expo/repack-app
187-
if: ${{ steps.apk-cache-restore.outputs.cache-hit == 'true' }}
188-
run: |
189-
echo "📦 Repacking APK with updated JavaScript bundle using @expo/repack-app..."
190-
# Use the optimized repack script which uses @expo/repack-app
191-
yarn build:repack:android
192-
echo "📦 Final APK size: $(du -h "${{ steps.determine-target-paths.outputs.apk-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}.apk" | cut -f1)"
193-
env:
194-
PLATFORM: android
195-
METAMASK_ENVIRONMENT: ${{ inputs.metamask_environment }}
196-
METAMASK_BUILD_TYPE: ${{ inputs.build_type }}
197-
IS_TEST: true
198-
E2E: 'true'
199-
IGNORE_BOXLOGS_DEVELOPMENT: true
200-
GITHUB_CI: 'true'
201-
CI: 'true'
202-
NODE_OPTIONS: '--max-old-space-size=8192'
203-
BRIDGE_USE_DEV_APIS: 'true'
204-
RAMP_INTERNAL_BUILD: 'true'
205-
SEEDLESS_ONBOARDING_ENABLED: 'true'
206-
MM_NOTIFICATIONS_UI_ENABLED: 'true'
207-
MM_SECURITY_ALERTS_API_ENABLED: 'true'
208-
MM_REMOVE_GLOBAL_NETWORK_SELECTOR: 'true'
209-
FEATURES_ANNOUNCEMENTS_ACCESS_TOKEN: ${{ secrets.FEATURES_ANNOUNCEMENTS_ACCESS_TOKEN }}
210-
FEATURES_ANNOUNCEMENTS_SPACE_ID: ${{ secrets.FEATURES_ANNOUNCEMENTS_SPACE_ID }}
211-
SEGMENT_WRITE_KEY_QA: ${{ secrets.SEGMENT_WRITE_KEY_QA }}
212-
SEGMENT_WRITE_KEY_FLASK: ${{ secrets.SEGMENT_WRITE_KEY_FLASK }}
213-
SEGMENT_PROXY_URL_QA: ${{ secrets.SEGMENT_PROXY_URL_QA }}
214-
SEGMENT_PROXY_URL_FLASK: ${{ secrets.SEGMENT_PROXY_URL_FLASK }}
215-
SEGMENT_DELETE_API_SOURCE_ID_QA: ${{ secrets.SEGMENT_DELETE_API_SOURCE_ID_QA }}
216-
SEGMENT_DELETE_API_SOURCE_ID_FLASK: ${{ secrets.SEGMENT_DELETE_API_SOURCE_ID_FLASK }}
217-
SEGMENT_REGULATIONS_ENDPOINT_QA: ${{ secrets.SEGMENT_REGULATIONS_ENDPOINT_QA }}
218-
SEGMENT_REGULATIONS_ENDPOINT_FLASK: ${{ secrets.SEGMENT_REGULATIONS_ENDPOINT_FLASK }}
219-
MM_SENTRY_DSN_TEST: ${{ secrets.MM_SENTRY_DSN_TEST }}
220-
MM_SENTRY_AUTH_TOKEN: ${{ secrets.MM_SENTRY_AUTH_TOKEN }}
221-
MAIN_IOS_GOOGLE_CLIENT_ID_UAT: ${{ secrets.MAIN_IOS_GOOGLE_CLIENT_ID_UAT }}
222-
FLASK_IOS_GOOGLE_CLIENT_ID_PROD: ${{ secrets.FLASK_IOS_GOOGLE_CLIENT_ID_PROD }}
223-
MAIN_IOS_GOOGLE_REDIRECT_URI_UAT: ${{ secrets.MAIN_IOS_GOOGLE_REDIRECT_URI_UAT }}
224-
FLASK_IOS_GOOGLE_REDIRECT_URI_PROD: ${{ secrets.FLASK_IOS_GOOGLE_REDIRECT_URI_PROD }}
225-
MAIN_ANDROID_APPLE_CLIENT_ID_UAT: ${{ secrets.MAIN_ANDROID_APPLE_CLIENT_ID_UAT }}
226-
FLASK_ANDROID_APPLE_CLIENT_ID_PROD: ${{ secrets.FLASK_ANDROID_APPLE_CLIENT_ID_PROD }}
227-
MAIN_ANDROID_GOOGLE_CLIENT_ID_UAT: ${{ secrets.MAIN_ANDROID_GOOGLE_CLIENT_ID_UAT }}
228-
FLASK_ANDROID_GOOGLE_CLIENT_ID_PROD: ${{ secrets.FLASK_ANDROID_GOOGLE_CLIENT_ID_PROD }}
229-
MAIN_ANDROID_GOOGLE_SERVER_CLIENT_ID_UAT: ${{ secrets.MAIN_ANDROID_GOOGLE_SERVER_CLIENT_ID_UAT }}
230-
FLASK_ANDROID_GOOGLE_SERVER_CLIENT_ID_PROD: ${{ secrets.FLASK_ANDROID_GOOGLE_SERVER_CLIENT_ID_PROD }}
231-
GOOGLE_SERVICES_B64_IOS: ${{ secrets.GOOGLE_SERVICES_B64_IOS }}
232-
GOOGLE_SERVICES_B64_ANDROID: ${{ secrets.GOOGLE_SERVICES_B64_ANDROID }}
233-
MM_INFURA_PROJECT_ID: ${{ secrets.MM_INFURA_PROJECT_ID }}
186+
# - name: Repack APK with JS updates using @expo/repack-app
187+
# if: ${{ steps.apk-cache-restore.outputs.cache-hit == 'true' }}
188+
# run: |
189+
# echo "📦 Repacking APK with updated JavaScript bundle using @expo/repack-app..."
190+
# # Use the optimized repack script which uses @expo/repack-app
191+
# yarn build:repack:android
192+
# echo "📦 Final APK size: $(du -h "${{ steps.determine-target-paths.outputs.apk-target-path }}/${{ steps.determine-target-paths.outputs.artifact_name }}.apk" | cut -f1)"
193+
# env:
194+
# PLATFORM: android
195+
# METAMASK_ENVIRONMENT: ${{ inputs.metamask_environment }}
196+
# METAMASK_BUILD_TYPE: ${{ inputs.build_type }}
197+
# IS_TEST: true
198+
# E2E: 'true'
199+
# IGNORE_BOXLOGS_DEVELOPMENT: true
200+
# GITHUB_CI: 'true'
201+
# CI: 'true'
202+
# NODE_OPTIONS: '--max-old-space-size=8192'
203+
# BRIDGE_USE_DEV_APIS: 'true'
204+
# RAMP_INTERNAL_BUILD: 'true'
205+
# SEEDLESS_ONBOARDING_ENABLED: 'true'
206+
# MM_NOTIFICATIONS_UI_ENABLED: 'true'
207+
# MM_SECURITY_ALERTS_API_ENABLED: 'true'
208+
# MM_REMOVE_GLOBAL_NETWORK_SELECTOR: 'true'
209+
# FEATURES_ANNOUNCEMENTS_ACCESS_TOKEN: ${{ secrets.FEATURES_ANNOUNCEMENTS_ACCESS_TOKEN }}
210+
# FEATURES_ANNOUNCEMENTS_SPACE_ID: ${{ secrets.FEATURES_ANNOUNCEMENTS_SPACE_ID }}
211+
# SEGMENT_WRITE_KEY_QA: ${{ secrets.SEGMENT_WRITE_KEY_QA }}
212+
# SEGMENT_WRITE_KEY_FLASK: ${{ secrets.SEGMENT_WRITE_KEY_FLASK }}
213+
# SEGMENT_PROXY_URL_QA: ${{ secrets.SEGMENT_PROXY_URL_QA }}
214+
# SEGMENT_PROXY_URL_FLASK: ${{ secrets.SEGMENT_PROXY_URL_FLASK }}
215+
# SEGMENT_DELETE_API_SOURCE_ID_QA: ${{ secrets.SEGMENT_DELETE_API_SOURCE_ID_QA }}
216+
# SEGMENT_DELETE_API_SOURCE_ID_FLASK: ${{ secrets.SEGMENT_DELETE_API_SOURCE_ID_FLASK }}
217+
# SEGMENT_REGULATIONS_ENDPOINT_QA: ${{ secrets.SEGMENT_REGULATIONS_ENDPOINT_QA }}
218+
# SEGMENT_REGULATIONS_ENDPOINT_FLASK: ${{ secrets.SEGMENT_REGULATIONS_ENDPOINT_FLASK }}
219+
# MM_SENTRY_DSN_TEST: ${{ secrets.MM_SENTRY_DSN_TEST }}
220+
# MM_SENTRY_AUTH_TOKEN: ${{ secrets.MM_SENTRY_AUTH_TOKEN }}
221+
# MAIN_IOS_GOOGLE_CLIENT_ID_UAT: ${{ secrets.MAIN_IOS_GOOGLE_CLIENT_ID_UAT }}
222+
# FLASK_IOS_GOOGLE_CLIENT_ID_PROD: ${{ secrets.FLASK_IOS_GOOGLE_CLIENT_ID_PROD }}
223+
# MAIN_IOS_GOOGLE_REDIRECT_URI_UAT: ${{ secrets.MAIN_IOS_GOOGLE_REDIRECT_URI_UAT }}
224+
# FLASK_IOS_GOOGLE_REDIRECT_URI_PROD: ${{ secrets.FLASK_IOS_GOOGLE_REDIRECT_URI_PROD }}
225+
# MAIN_ANDROID_APPLE_CLIENT_ID_UAT: ${{ secrets.MAIN_ANDROID_APPLE_CLIENT_ID_UAT }}
226+
# FLASK_ANDROID_APPLE_CLIENT_ID_PROD: ${{ secrets.FLASK_ANDROID_APPLE_CLIENT_ID_PROD }}
227+
# MAIN_ANDROID_GOOGLE_CLIENT_ID_UAT: ${{ secrets.MAIN_ANDROID_GOOGLE_CLIENT_ID_UAT }}
228+
# FLASK_ANDROID_GOOGLE_CLIENT_ID_PROD: ${{ secrets.FLASK_ANDROID_GOOGLE_CLIENT_ID_PROD }}
229+
# MAIN_ANDROID_GOOGLE_SERVER_CLIENT_ID_UAT: ${{ secrets.MAIN_ANDROID_GOOGLE_SERVER_CLIENT_ID_UAT }}
230+
# FLASK_ANDROID_GOOGLE_SERVER_CLIENT_ID_PROD: ${{ secrets.FLASK_ANDROID_GOOGLE_SERVER_CLIENT_ID_PROD }}
231+
# GOOGLE_SERVICES_B64_IOS: ${{ secrets.GOOGLE_SERVICES_B64_IOS }}
232+
# GOOGLE_SERVICES_B64_ANDROID: ${{ secrets.GOOGLE_SERVICES_B64_ANDROID }}
233+
# MM_INFURA_PROJECT_ID: ${{ secrets.MM_INFURA_PROJECT_ID }}
234234

235235
# Cache build artifacts with the pre-build fingerprint
236236
- name: Cache build artifacts

0 commit comments

Comments
 (0)