Commit ff0fd5a
authored
test: Fix Snaps E2E after settings changes (#22933)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
A recent change to the settings pages broke a Snaps E2E test on main.
This PR fixes that by adding additional steps to exit the settings menu.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Fix Snaps E2E by adding back-navigation support and updating tests to
exit Settings before proceeding.
>
> - **E2E Page Objects**:
> - `e2e/pages/Settings/SnapSettingsView.ts`:
> - Add `backButton` getter using
`CommonSelectorsIDs.BACK_ARROW_BUTTON`.
> - Add `tapBackButton()` to tap the back arrow.
> - **E2E Tests**:
> - `e2e/specs/snaps/test-snap-management.spec.ts`:
> - After toggling Snap enablement, navigate out of Settings via two
`tapBackButton()` calls and `SettingsView.tapCloseButton()` before
continuing.
> - Ensure `SettingsView.tapSnaps()` is invoked where needed before
selecting a Snap.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
00b8efc. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent fa0c583 commit ff0fd5a
File tree
2 files changed
+21
-0
lines changed- e2e
- pages/Settings
- specs/snaps
2 files changed
+21
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
17 | 22 | | |
18 | 23 | | |
19 | 24 | | |
| |||
36 | 41 | | |
37 | 42 | | |
38 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
39 | 50 | | |
40 | 51 | | |
41 | 52 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
44 | 48 | | |
45 | 49 | | |
46 | 50 | | |
| |||
61 | 65 | | |
62 | 66 | | |
63 | 67 | | |
| 68 | + | |
64 | 69 | | |
65 | 70 | | |
66 | 71 | | |
67 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
68 | 77 | | |
69 | 78 | | |
70 | 79 | | |
| |||
86 | 95 | | |
87 | 96 | | |
88 | 97 | | |
| 98 | + | |
89 | 99 | | |
90 | 100 | | |
91 | 101 | | |
| |||
0 commit comments