fix: Fix/10029 background bridge origin #13698

Cal-L · 2025-02-24T20:28:40Z

Description

This PR updates the BackgroundBridge to properly set the origin property instead of using hostname. This is important because the origin that dependents consume. Previously, we used hostname, which omitted protocol. Changing to origin will resolve that

Related issues

Fixes: #11029

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-24T20:28:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-02-24T20:29:39Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 7bfbb3c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b00325ff-55c7-4541-9f9e-ea34e045bcbb

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…0029-background-bridge-origin

socket-security · 2025-02-26T00:38:53Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/pump@1.1.3	None	`0`	3.57 kB	types
npm/@types/readable-stream@4.0.18	None	`+1`	63.4 kB	types

View full report↗︎

Have feedback? Participate in our User Experience Survey 📊

Cal-L · 2025-02-26T00:39:03Z

app/util/browserScripts.ts

 ) => `(function () {
  try {
    window.postMessage(${JSON.stringify(message)}, '${origin}');
  } catch (e) {
    //Nothing to do
  }
 })()`;
-
-export const JS_IFRAME_POST_MESSAGE_TO_PROVIDER = (


Removed since not used for a while

Cal-L · 2025-02-26T00:39:19Z

app/util/middlewares.js

@@ -18,7 +18,7 @@ const USER_REJECTED_ERROR_CODE = 4001;
 /**
 * Returns a middleware that appends the DApp origin to request
 * @param {{ origin: string }} opts - The middleware options
- * @returns {Function}


Updating to use the correct types

Cal-L · 2025-02-26T00:40:27Z

app/util/transactions/index.js

@@ -595,6 +626,7 @@ export function getNormalizedTxState(state) {
    : undefined;
 }

+// FIXME: Check if the url here is origin and not hostname


verify that this is not hostname

Cal-L · 2025-02-26T00:40:41Z

babel.config.js

@@ -40,6 +40,10 @@ module.exports = {
      test: './app/core/Engine/Engine.ts',
      plugins: [['@babel/plugin-transform-private-methods', { loose: true }]],
    },
+    {
+      test: './app/core/BackgroundBridge/BackgroundBridge.ts',


BackgroundBridge uses # prefix for private

Cal-L · 2025-02-26T00:41:28Z

package.json

@@ -440,6 +441,7 @@
    "@types/react-native-svg-charts": "^5.0.12",
    "@types/react-native-vector-icons": "^6.4.13",
    "@types/react-native-video": "^5.0.14",
+    "@types/readable-stream": "^4.0.18",


Converted requires to imports, so needed types for both packages

Cal-L · 2025-02-26T00:42:16Z

app/selectors/snaps/permissionController.ts

+ * @param subject - The subject to get the permitted accounts for
+ * @returns A selector that returns the permitted accounts for the given subject
+ */
+export const selectPermittedAccounts = (subject: string) =>


Add new selector for getting permitted accounts by subject

Cal-L · 2025-02-26T00:42:36Z

app/selectors/snaps/permissionController.ts


 export const selectPermissionControllerState = (state: RootState) =>
-  state.engine.backgroundState.PermissionController;
+  state.engine.backgroundState
+    .PermissionController as PermissionControllerState<PermissionConstraint>;


Give selector return type

Cal-L · 2025-02-26T00:43:20Z

app/declarations/index.d.ts

@@ -295,3 +295,7 @@ declare module '@metamask/react-native-actionsheet' {
 }

 declare module '@metamask/react-native-search-api';
+
+// Resolve BackgroundBridge import errors related to TS
+declare module '@metamask/eth-json-rpc-filters';


Both of these libs are JS. These are added to supress TS errors associated with importing them

sonarqubecloud · 2025-02-26T20:07:37Z

Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Cal-L added 7 commits February 20, 2025 15:06

Update Engine controller readme for assigning codeowners

878ae8d

Merge branch 'main' of github.com:MetaMask/metamask-mobile

a497403

Merge branch 'main' of github.com:MetaMask/metamask-mobile

1616614

Allow # prefix in BackgroundBridge

2dec68f

Convert BackgroundBridge to TS

44f6f7d

Update types and clean up inputs

1d28f38

Fix lint issues

7bfbb3c

metamaskbot added the team-mobile-platform Mobile Platform team label Feb 24, 2025

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 24, 2025

Make BackgroundBridge feature agnostic

2c14bcf

gauthierpetetin assigned Cal-L Feb 25, 2025

Cal-L added 9 commits February 25, 2025 16:30

Update permission screens to use origin

aea5da9

Update browser to use origin

e786d63

Update new permission UI to use origin

738d093

Update SDK files to use origin

cb1fb43

Update WC files to use origin

dfcb83e

Update middleware to use origin

6aa55ae

Update background bridge to use origin

8b3dbc9

Update utils to use origin

faf3af6

Merge branch 'main' of github.com:MetaMask/metamask-mobile into fix/1…

60146b0

…0029-background-bridge-origin

Cal-L commented Feb 26, 2025

View reviewed changes

Cal-L added 4 commits February 25, 2025 16:52

Rename bridges subject

bed12e3

Fix unit tests

5d54a49

Begin fixing unit tests

ee46ab1

Fix unit tests for middleware

b395229

digiwand linked an issue Feb 27, 2025 that may be closed by this pull request

[Bug]: Redesign signature origin may display "https" instead of the origin #13757

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix/10029 background bridge origin #13698

fix: Fix/10029 background bridge origin #13698

Cal-L commented Feb 24, 2025

github-actions bot commented Feb 24, 2025

github-actions bot commented Feb 24, 2025

socket-security bot commented Feb 26, 2025 •

edited

Loading

Cal-L Feb 26, 2025

Cal-L Feb 26, 2025

Cal-L Feb 26, 2025

Cal-L Feb 26, 2025

Cal-L Feb 26, 2025

Cal-L Feb 26, 2025

Cal-L Feb 26, 2025

Cal-L Feb 26, 2025

sonarqubecloud bot commented Feb 26, 2025

fix: Fix/10029 background bridge origin #13698

Are you sure you want to change the base?

fix: Fix/10029 background bridge origin #13698

Conversation

Cal-L commented Feb 24, 2025

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 24, 2025

github-actions bot commented Feb 24, 2025

Bitrise

socket-security bot commented Feb 26, 2025 • edited Loading

Have feedback? Participate in our User Experience Survey 📊

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 26, 2025

Quality Gate failed

socket-security bot commented Feb 26, 2025 •

edited

Loading