Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): payment method selector UI update #13722

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

georgeweiler
Copy link
Contributor

Description

This PR updates the user interface of the ramp payment method selector by exposing the available payment method icons. It also updates the CTA copy and adds tests

Related issues

Fixes:

Manual testing steps

  1. Visit the ramp page
  2. verify that the payment method icons are rendered

Screenshots/Recordings

Before

Screenshot 2025-02-25 at 12 05 14 PM

After

Screenshot 2025-02-25 at 10 20 18 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

georgeweiler and others added 30 commits February 13, 2025 08:28
…tamask-mobile into feat/most-reliable-quote-tag
…tamask-mobile into feat/most-reliable-quote-tag
…tamask-mobile into feat/most-reliable-quote-tag
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Feb 25, 2025
@georgeweiler georgeweiler added needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 74b00d6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a5bfbab-41b6-4f30-9a3d-56c54c04575f

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@georgeweiler georgeweiler marked this pull request as ready for review February 25, 2025 19:09
@georgeweiler georgeweiler requested a review from a team as a code owner February 25, 2025 19:09
@georgeweiler georgeweiler marked this pull request as draft February 25, 2025 20:19
@georgeweiler georgeweiler marked this pull request as ready for review February 27, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants