-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: update account item list selection element to fix flakiness #15206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
chrisleewilcox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
regression pipeline run - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/870f0656-1dec-48fd-9566-b660380c462e |
cortisiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮
|
|



Description
The action to select and account from the account list, or when long pressing for removing accounts. This was tapping on the
select-with-menupreviously which was tapping the middle of the account list element i.e wallet address.I have raised this low severity bug
This
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist