Skip to content

Conversation

@cmd-ob
Copy link
Contributor

@cmd-ob cmd-ob commented May 7, 2025

Description

The action to select and account from the account list, or when long pressing for removing accounts. This was tapping on the select-with-menu previously which was tapping the middle of the account list element i.e wallet address.

I have raised this low severity bug

This

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cmd-ob cmd-ob requested a review from cortisiko May 7, 2025 11:42
@metamaskbot metamaskbot added the team-qa QA team label May 7, 2025
@cmd-ob cmd-ob requested a review from Andepande May 7, 2025 11:42
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d104981
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/131c6112-cfb1-47ba-9502-d8c5d6e89586

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmd-ob
Copy link
Contributor Author

cmd-ob commented May 7, 2025

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b79f334
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2c728298-1a58-414f-8ef3-859d6bfdfdd3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cmd-ob cmd-ob added the No QA Needed Apply this label when your PR does not need any QA effort. label May 7, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

@cmd-ob cmd-ob added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit e3b9fc2 May 7, 2025
49 of 55 checks passed
@cmd-ob cmd-ob deleted the fix/select-account-action-e2e branch May 7, 2025 18:09
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants