feat: cp-7.47.0 solana code fences #15297

aganglada · 2025-05-13T16:27:21Z

Description

enables the Solana and Non-EVM code by moving the code fence flags to the main set.
this change makes all the Solana and Non-EVM features available in main build.
updates e2e tests to take the new modal into account

Note

The keyring-snaps is the code fence flag that allows for snaps like the solana, bitcoin, any keyring snap to work, the Solana snap and bitcoin snap are keyring-snaps.
This code fence has all the broad/general code for non-evm snaps, and then for specific network logic we have the solana, bitcoin etc...

Related issues

Fixes: the current feature is under code fencing, only available in our beta build, it has to be moved from beta to main set to be available in the next release.

Manual testing steps

Feature: Solana

  Scenario: user opens new app install
    Given the app is installed and wallet created
    When user lands on wallet screen
    Then user sees the new Solana feature announcement bottom sheet
    And user sees in the accounts list "add Solana account"
    And user sees in the network tab "Solana"

  Scenario: user opens updated app
    Given the app is updated with wallet already created
    When user logs in
    Then user sees the new Solana feature announcement bottom sheet
    And user sees in the accounts list "add Solana account"
    And user sees in the network tab "Solana"

Screenshots/Recordings

Before

Add account

Select network

After

New welcome bottom sheet

Add account

Select network

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-13T16:27:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov-commenter · 2025-05-13T17:21:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (5113000) to head (8eb86ad).
Report is 39 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15297      +/-   ##
==========================================
+ Coverage   68.46%   68.69%   +0.23%     
==========================================
  Files        2372     2381       +9     
  Lines       51275    51432     +157     
  Branches     7634     7663      +29     
==========================================
+ Hits        35103    35333     +230     
+ Misses      13942    13853      -89     
- Partials     2230     2246      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-05-14T17:24:52Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e98a1ca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/39d1e486-c43a-4dbc-9ccb-79e1b006c8fa

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-05-15T08:32:53Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e205ad2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a3fd4be-4f11-42b7-a2a7-a6c8b14f399a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

NicolasMassart

I tested (built the feature, provided screenshots in description) and I approve the changes, we just have to make sure the e2e failures are not related to this PR to merge.
QA team can help on this. Contact them please.

aganglada · 2025-05-15T13:23:51Z

I tested (built the feature, provided screenshots in description) and I approve the changes, we just have to make sure the e2e failures are not related to this PR to merge. QA team can help on this. Contact them please.

@Andepande is on it

## **Description** Got it! Here's an updated PR description that includes those details: --- Fixes existing smoke E2E test failures that occur when the Solana feature is enabled. * Suppresses the Solana feature sheet for tests that use fixtures. * For tests that don’t use fixtures, automatically swipes down to dismiss the modal. This ensures stability across smoke tests regardless of the Solana feature flag state. --- Let me know if you'd like to mention specific test files or tag reviewers.  ## **Related issues** Fixes: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a3fd4be-4f11-42b7-a2a7-a6c8b14f399a ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-16T08:01:16Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: abcfa8f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5ac2c08-7566-43ee-bc38-e53c1fe1c91b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-05-16T08:35:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

NicolasMassart

I approve these e2e changes and addition of test ids in the UI

feat: solana code fences

8eb86ad

aganglada self-assigned this May 13, 2025

aganglada requested a review from a team May 13, 2025 16:27

aganglada requested a review from a team as a code owner May 13, 2025 16:27

metamaskbot added the team-new-networks label May 13, 2025

aganglada added QA Passed QA testing has been completed and passed Run Smoke E2E labels May 14, 2025

This comment was marked as outdated.

Sign in to view

NicolasMassart changed the title ~~feat: solana code fences cp-7.47.0~~ feat: cp-7.47.0 solana code fences May 14, 2025

aganglada added Run Smoke E2E and removed Run Smoke E2E labels May 14, 2025

NicolasMassart removed the QA Passed QA testing has been completed and passed label May 14, 2025

NicolasMassart marked this pull request as draft May 14, 2025 14:44

NicolasMassart self-assigned this May 14, 2025

zone-live added the No QA Needed Apply this label when your PR does not need any QA effort. label May 14, 2025

Merge branch 'main' into feat/solana-code-fences

e98a1ca

zone-live added Run Smoke E2E and removed Run Smoke E2E labels May 14, 2025

zone-live marked this pull request as ready for review May 15, 2025 08:21

Merge branch 'main' into feat/solana-code-fences

e205ad2

zone-live added Run Smoke E2E and removed Run Smoke E2E labels May 15, 2025

tommasini previously approved these changes May 15, 2025

View reviewed changes

NicolasMassart previously approved these changes May 15, 2025

View reviewed changes

Andepande dismissed stale reviews from NicolasMassart and tommasini via abcfa8f May 16, 2025 07:54

Andepande added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E and removed No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels May 16, 2025

Merge branch 'main' into feat/solana-code-fences

56b45c0

metamaskbot added the bitrise-result-ready label May 16, 2025

github-actions bot removed the bitrise-result-ready label May 16, 2025

NicolasMassart approved these changes May 16, 2025

View reviewed changes

NicolasMassart added this pull request to the merge queue May 16, 2025

Merged via the queue into main with commit 8ab1426 May 16, 2025
43 of 44 checks passed

NicolasMassart deleted the feat/solana-code-fences branch May 16, 2025 08:59

github-actions bot locked and limited conversation to collaborators May 16, 2025

metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: cp-7.47.0 solana code fences #15297

feat: cp-7.47.0 solana code fences #15297

Uh oh!

aganglada commented May 13, 2025 •

edited by NicolasMassart

Loading

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

codecov-commenter commented May 13, 2025

Uh oh!

This comment was marked as outdated.

github-actions bot commented May 14, 2025 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented May 15, 2025 •

edited by metamaskbot

Loading

Uh oh!

NicolasMassart left a comment

Uh oh!

aganglada commented May 15, 2025

Uh oh!

github-actions bot commented May 16, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud bot commented May 16, 2025

Uh oh!

NicolasMassart left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

feat: cp-7.47.0 solana code fences #15297

feat: cp-7.47.0 solana code fences #15297

Uh oh!

Conversation

aganglada commented May 13, 2025 • edited by NicolasMassart Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

Add account

Select network

After

New welcome bottom sheet

Add account

Select network

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

codecov-commenter commented May 13, 2025

Codecov Report

Uh oh!

This comment was marked as outdated.

github-actions bot commented May 14, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented May 15, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

NicolasMassart left a comment

Choose a reason for hiding this comment

Uh oh!

aganglada commented May 15, 2025

Uh oh!

github-actions bot commented May 16, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented May 16, 2025

Quality Gate passed

Uh oh!

NicolasMassart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

aganglada commented May 13, 2025 •

edited by NicolasMassart

Loading

github-actions bot commented May 14, 2025 •

edited by metamaskbot

Loading

github-actions bot commented May 15, 2025 •

edited by metamaskbot

Loading

github-actions bot commented May 16, 2025 •

edited by metamaskbot

Loading