Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented May 14, 2025

Description

Migration files should never be removed once added, as this creates a
mismatch between the the number of the final migration and the total
number of migrations, and so new migrations that are added later could
be skipped.

This commit adds back migration 73, which was removed in a previous
commit, except that it replaces it with a version that does nothing.

Related issues

Fixes #15306.

Manual testing steps

  • Check out this branch.
  • Open app/store/migrations/index.ts and comment out the final
    migration (78).
  • Open app/store/persistConfig.ts and change migrate: createMigrate(migrations, { debug: false }), to migrate: createMigrate(migrations, { debug: true }),.
  • Run yarn setup:expo and yarn watch:clean.
  • Remove the app from your device or local emulator first (you can also
    simply clear all app storage on Android).
  • Open the app, go through onboarding, and create an account.
  • Now reopen app/store/migrations/index.ts and uncomment migration 78
    so that it will run.
  • Reload the app.
  • Look for a line starting with redux-persist. You should see that
    migration 78 ran (not 77).

Screenshots/Recordings

Before

After

This is what you should see:

Screenshot 2025-05-13 at 3 20 44 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Co-authored-by: Nico MASSART NicolasMassart@users.noreply.github.com 230571f

…r migration 73 (#15302)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Migration files should never be removed once added, as this creates a
mismatch between the the number of the final migration and the total
number of migrations, and so new migrations that are added later could
be skipped.

This commit adds back migration 73, which was removed in a previous
commit, except that it replaces it with a version that does nothing.

## **Related issues**

Fixes #15306.

## **Manual testing steps**

- Check out this branch.
- Open `app/store/migrations/index.ts` and comment out the final
migration (78).
- Open `app/store/persistConfig.ts` and change `migrate:
createMigrate(migrations, { debug: false }),` to `migrate:
createMigrate(migrations, { debug: true }),`.
- Run `yarn setup:expo` and `yarn watch:clean`.
- Remove the app from your device or local emulator first (you can also
simply clear all app storage on Android).
- Open the app, go through onboarding, and create an account.
- Now reopen `app/store/migrations/index.ts` and uncomment migration 78
so that it will run.
- Reload the app.
- Look for a line starting with `redux-persist`. You should see that
migration 78 ran (not 77).

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

This is what you should see:

<img width="608" alt="Screenshot 2025-05-13 at 3 20 44 PM"
src="https://github.com/user-attachments/assets/32f8364b-f7f3-466c-b59e-c5a81e047497"
/>

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
@runway-github runway-github bot requested a review from a team May 14, 2025 12:17
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label May 14, 2025
@sonarqubecloud
Copy link

@NicolasMassart NicolasMassart merged commit ae4352a into release/7.47.0 May 14, 2025
38 of 40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
@NicolasMassart NicolasMassart deleted the runway-cherry-pick-7.47.0-1747225037 branch May 14, 2025 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants