Skip to content

Conversation

@owencraston
Copy link
Contributor

Description

Render a toast indicating that solana dapp connectivity is coming soon when a user opens the in app browser and their current account is a Solana account.

Design is here:
https://www.figma.com/design/VqbOpEAsKGogdhZ5IsL4Pu/Solana?m=auto&node-id=2771-7777&t=IUlpwfo4owE10Ybw-1

Related issues

Fixes: #14563

Manual testing steps

  1. ensure that you are building beta by editing your METAMASK_BUILD_TYPE to beta in the .js.env file
  2. import or create a wallet
  3. create a solona account
  4. ensure that the solana account is selected
  5. navigate to the browser
  6. you should see the Toast that matches the designs pop up
  7. now navigate back to the wallet view and select an ethereum account
  8. navigate back to the browser
  9. notice that the toast does not pop up

Screenshots/Recordings

Before

After

Screenshot 2025-05-08 at 9 42 31 PM
screen-20250508-212013.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

Render a toast indicating that solana dapp connectivity is coming soon
when a user opens the in app browser and their current account is a
Solana account.

Design is here:
https://www.figma.com/design/VqbOpEAsKGogdhZ5IsL4Pu/Solana?m=auto&node-id=2771-7777&t=IUlpwfo4owE10Ybw-1

## **Related issues**

Fixes: #14563

## **Manual testing steps**

1. ensure that you are building beta by editing your
`METAMASK_BUILD_TYPE` to `beta` in the `.js.env` file
2. import or create a wallet
3. create a solona account
4. ensure that the solana account is selected
5. navigate to the browser
6. you should see the Toast that matches the designs pop up
7. now navigate back to the wallet view and select an ethereum account
8. navigate back to the browser
9. notice that the toast does not pop up

## **Screenshots/Recordings**

### **Before**


### **After**

<img width="459" alt="Screenshot 2025-05-08 at 9 42 31 PM"
src="https://github.com/user-attachments/assets/c54c05f3-5e92-443d-b4d2-22408021d507"
/>



https://github.com/user-attachments/assets/6ed3aa9e-e5fe-4715-8146-e5c0a3237ddf


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@owencraston owencraston marked this pull request as ready for review May 14, 2025 21:24
@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label May 14, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 100aa71
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a715afea-2fae-4e6f-9ed1-a03c5457d077

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

gantunesr
gantunesr previously approved these changes May 14, 2025
@gantunesr gantunesr dismissed their stale review May 14, 2025 21:28

dismissing review because of failed CI

@sonarqubecloud
Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/7.47.0@795328f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/components/Views/Browser/index.js 70.83% 7 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/7.47.0   #15339   +/-   ##
=================================================
  Coverage                  ?   68.65%           
=================================================
  Files                     ?     2377           
  Lines                     ?    51331           
  Branches                  ?     7640           
=================================================
  Hits                      ?    35240           
  Misses                    ?    13850           
  Partials                  ?     2241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@owencraston owencraston merged commit 367ca0d into release/7.47.0 May 15, 2025
46 of 49 checks passed
@owencraston owencraston deleted the feat/cherry-pick-15224 branch May 15, 2025 13:17
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants