-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Solana dapp connectivity announcement toast (cherry pick from #15224) #15339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## **Description** Render a toast indicating that solana dapp connectivity is coming soon when a user opens the in app browser and their current account is a Solana account. Design is here: https://www.figma.com/design/VqbOpEAsKGogdhZ5IsL4Pu/Solana?m=auto&node-id=2771-7777&t=IUlpwfo4owE10Ybw-1 ## **Related issues** Fixes: #14563 ## **Manual testing steps** 1. ensure that you are building beta by editing your `METAMASK_BUILD_TYPE` to `beta` in the `.js.env` file 2. import or create a wallet 3. create a solona account 4. ensure that the solana account is selected 5. navigate to the browser 6. you should see the Toast that matches the designs pop up 7. now navigate back to the wallet view and select an ethereum account 8. navigate back to the browser 9. notice that the toast does not pop up ## **Screenshots/Recordings** ### **Before** ### **After** <img width="459" alt="Screenshot 2025-05-08 at 9 42 31 PM" src="https://github.com/user-attachments/assets/c54c05f3-5e92-443d-b4d2-22408021d507" /> https://github.com/user-attachments/assets/6ed3aa9e-e5fe-4715-8146-e5c0a3237ddf ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/7.47.0 #15339 +/- ##
=================================================
Coverage ? 68.65%
=================================================
Files ? 2377
Lines ? 51331
Branches ? 7640
=================================================
Hits ? 35240
Misses ? 13850
Partials ? 2241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Description
Render a toast indicating that solana dapp connectivity is coming soon when a user opens the in app browser and their current account is a Solana account.
Design is here:
https://www.figma.com/design/VqbOpEAsKGogdhZ5IsL4Pu/Solana?m=auto&node-id=2771-7777&t=IUlpwfo4owE10Ybw-1
Related issues
Fixes: #14563
Manual testing steps
METAMASK_BUILD_TYPEtobetain the.js.envfileScreenshots/Recordings
Before
After
screen-20250508-212013.mp4
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist