Skip to content

Conversation

@brianacnguyen
Copy link
Contributor

Description

This PR aligned and updated the tabs styling in the wallet screen

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5244

Manual testing steps

  1. Go to Wallet

Screenshots/Recordings

Before

After

Tabs.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jun 30, 2025
@brianacnguyen brianacnguyen requested a review from a team June 30, 2025 15:21
@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system in Mobile label Jun 30, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f44022c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7339e9e7-7e99-4a55-b580-784ab6c2e027

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4eadf23
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ba8bbdc7-b636-4a9f-97b9-e2a611f2e860

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@brianacnguyen brianacnguyen added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 124e695 Jul 9, 2025
59 of 61 checks passed
@brianacnguyen brianacnguyen deleted the homepage/tabs branch July 9, 2025 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
@amandaye0h
Copy link
Contributor

@brianacnguyen Looks like the border is still missing for the inactive tabs — has the video been updated? Would it be possible to include it so it aligns with the designs?
Screenshot 2025-07-10 at 5 46 29 AM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants