Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 3, 2025

Description

Add page for user to opt in for smart account

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5262

Manual testing steps

  1. Go to test dapp and submit 5792 request
  2. On splash page you should be able to opt-in for multiple accounts

Screenshots/Recordings

Splash page:
Screenshot 2025-07-09 at 12 01 02 PM

Slide:

Screen.Recording.2025-07-09.at.11.58.58.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jul 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri marked this pull request as ready for review July 4, 2025 09:46
@jpuri jpuri requested a review from a team as a code owner July 4, 2025 09:46
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@jpuri jpuri requested a review from a team as a code owner July 8, 2025 16:31
@jpuri jpuri changed the title feat: Adding account selection to splash page feat: Add page for user to opt in Jul 8, 2025
cursor[bot]

This comment was marked as outdated.

@jpuri jpuri changed the title feat: Add page for user to opt in feat: Add page for user to opt in for smart account Jul 9, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@jpuri jpuri enabled auto-merge July 9, 2025 06:34
@jpuri jpuri added Run Smoke E2E and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 816be55
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/30ffab12-e6b7-4f30-b713-d36b28801277

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

OGPoyraz
OGPoyraz previously approved these changes Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7126936
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e456afe1-7ef4-4546-98aa-daef170d6640

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

@jpuri jpuri added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit c9647f8 Jul 9, 2025
51 of 57 checks passed
@jpuri jpuri deleted the account_selection branch July 9, 2025 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants