Skip to content

Conversation

@smgv
Copy link
Contributor

@smgv smgv commented Jul 7, 2025

Description

Related issues

Fixes:

Manual testing steps

  1. Go to the app.
  2. While creating a wallet, skip.
  3. Get to the optinMetric Screen and close the app.
  4. Login again, it should again show the optinMetric Screen, and now click on the agree or cancel button.
  5. Relogin again now you should redirect to Home Page.

Screenshots/Recordings

Before

MetaMetricsUI

After

2025-07-09.19.38.10.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@smgv smgv requested review from chaitanyapotti and ieow July 7, 2025 09:10
@smgv smgv self-assigned this Jul 7, 2025
@smgv smgv requested a review from a team as a code owner July 7, 2025 09:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@hieu-w hieu-w force-pushed the fix/optin-metric-flow branch from 211c7fa to c054cab Compare July 9, 2025 07:26
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fd9ab52
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97988ab6-aa00-4a26-b35c-e281efa71b6c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.07%. Comparing base (7e7823f) to head (c4169bb).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/OptinMetrics/index.js 66.66% 1 Missing ⚠️
app/components/Views/Login/index.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16953      +/-   ##
==========================================
+ Coverage   72.82%   73.07%   +0.24%     
==========================================
  Files        2742     2749       +7     
  Lines       59587    59896     +309     
  Branches     9409     9476      +67     
==========================================
+ Hits        43397    43770     +373     
+ Misses      13440    13370      -70     
- Partials     2750     2756       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c4169bb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1418db44-d079-4ee3-a413-9a69da2209a6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Jul 9, 2025
@LeVinhGithub LeVinhGithub added the QA Passed QA testing has been completed and passed label Jul 9, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 9, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 7f7778f Jul 9, 2025
67 of 71 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/optin-metric-flow branch July 9, 2025 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding INVALID-PR-TEMPLATE PR's body doesn't match template QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-onboarding Onboarding team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants