Skip to content

Conversation

@stanleyyconsensys
Copy link
Contributor

@stanleyyconsensys stanleyyconsensys commented Jul 9, 2025

Description

This PR is fixed the block explorer URL doesnt not return correctly for bridge transaction

it is because the previous method is heavy depends on etherscan-link to get the URL

on the other hand, if the hashmap of network <> block explorer url is not up to date, there will be an issue (it only support 0x1)

In this fix, we copy the same behavior with app/components/hooks/useBlockExplorer.ts to have minimal change to fix the issue

Changelog

CHANGELOG entry: Fixed missing explorer url in bridge transaction

Related issues

Fixes: #16109

Manual testing steps

  1. Make a bridge transaction from one the network - Mainnet, Sepolia, Linea Mainnet, Linea Sepolia, and Base
  2. And check the tx histroy after the tx complete
  3. We should see 2 explorer URL

Screenshots/Recordings

Before

After

image Screenshot 2025-07-09 at 4 01 52 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@stanleyyconsensys stanleyyconsensys self-assigned this Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@stanleyyconsensys stanleyyconsensys changed the title ix: cp-7.51.0 missing explorer url in bridge tx fix: cp-7.51.0 missing explorer url in bridge tx Jul 9, 2025
@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review July 9, 2025 08:03
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner July 9, 2025 08:03
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d064137
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70cca952-3243-448d-95d5-a80300a02d0d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

@stanleyyconsensys stanleyyconsensys force-pushed the fix/bridge-explorer-url branch from 9ab2b8f to 5a47fe9 Compare July 9, 2025 09:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

@stanleyyconsensys stanleyyconsensys added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E and removed Run Smoke E2E labels Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5a47fe9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/41071590-6766-43d1-a887-4167f980953a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 0385ea0 Jul 9, 2025
58 of 62 checks passed
@stanleyyconsensys stanleyyconsensys deleted the fix/bridge-explorer-url branch July 9, 2025 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-network-enablement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Bridge Transaction showing incorrect explorer link

4 participants