Skip to content

chore: Bump Snaps packages #17051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2025
Merged

chore: Bump Snaps packages #17051

merged 6 commits into from
Jul 10, 2025

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jul 10, 2025 •
edited
Loading

Description

This bumps Snaps packages to the latest version. Notable changes include:

  • Support for NFTs in the Snaps Asset API
  • A feature flag to force local Snaps to be have like preinstalled Snaps for development purposes
  • Allow all children in Row

Related issues

Fixes: #16696

@metamaskbot metamaskbot added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Jul 10, 2025
@socket-security
Copy link

socket-security bot commented Jul 10, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​snaps-controllers@​14.0.2 ⏵ 14.1.09610074 +1100 +150
Updatednpm/​@​metamask/​snaps-execution-environments@​10.0.0 ⏵ 10.1.097 -1100759980

View full report

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4488aed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/700aad81-7d35-4989-8e67-c7e07deca481

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 10, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
62.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@FrederikBolding FrederikBolding added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed Run Flask E2E labels Jul 10, 2025
@FrederikBolding FrederikBolding marked this pull request as ready for review July 10, 2025 10:51
@FrederikBolding FrederikBolding requested review from a team as code owners July 10, 2025 10:51
cursor[bot]
cursor bot reviewed Jul 10, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Conditional Feature Flag Causes Test Failures

The test expects forcePreinstalledSnaps: false in the featureFlags object, but this property is only present in Flask builds due to conditional compilation. This causes the test to fail in non-Flask builds where the property is absent.

app/core/Engine/controllers/snaps/snap-controller-init.test.ts#L67-L68

metamask-mobile/app/core/Engine/controllers/snaps/snap-controller-init.test.ts

Lines 67 to 68 in 4488aed

useCaip25Permission: true,
forcePreinstalledSnaps: false,

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

ccharly
ccharly approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for accounts files.

app/core/SnapKeyring/utils/snaps.ts

@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 986898d Jul 10, 2025
81 of 95 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v119 branch July 10, 2025 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@ccharly ccharly ccharly approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.52.0 Issue or pull request that will be included in release 7.52.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Snap dialog button has inconsistent font color with the platform

5 participants

@FrederikBolding @ccharly @GuillaumeRx @metamaskbot