feat(deposit): transactions analytics

[AxelGes]

Description

This PR adds analytics tracking for Transaction related events. (Confirmed, Completed, Failed)

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: a3fd8bf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da676a14-eb34-40d7-8915-514588319433

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: cb9fafc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/63b35ded-49a3-4507-a069-6bd3cb5905d7

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d744471
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27550280-89cb-49be-99f5-5c16f57d4fd9

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e0f8a6a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/15a254fc-3026-40a8-a0a4-92b251548886

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​consensys/​native-ramps-sdk@​1.0.12 ⏵ 1.1.0	+14		+1	+3	+20

View full report

[cursor]

Bug: Unnecessary Dependencies Cause Duplicate Analytics Events

The useEffect hook responsible for tracking RAMPS_TRANSACTION_COMPLETED and RAMPS_TRANSACTION_FAILED analytics events has an overly broad dependency array. It includes navigation and orderId, which are not used within the effect's analytics logic, and depends on the entire order object. This causes the effect to re-run unnecessarily and fire duplicate analytics events whenever these dependencies change, even if the order's completion or failure state has not changed.

app/components/UI/Ramp/Deposit/Views/OrderProcessing/OrderProcessing.tsx#L87-L146

metamask-mobile/app/components/UI/Ramp/Deposit/Views/OrderProcessing/OrderProcessing.tsx

Lines 87 to 146 in d125ef0

	useEffect(() => {
	if (!order) return;
	const isCompleted = order.state === FIAT_ORDER_STATES.COMPLETED;
	const isFailed = order.state === FIAT_ORDER_STATES.FAILED;
	if (isCompleted || isFailed) {
	if (hasDepositOrderField(order.data, 'cryptoCurrency')) {
	const cryptoCurrency = getCryptoCurrencyFromTransakId(
	(order.data as DepositOrder).cryptoCurrency,
	);
	const baseAnalyticsData = {
	ramp_type: 'DEPOSIT' as const,
	amount_source: Number(order.data.fiatAmount),
	amount_destination: Number(order.cryptoAmount),
	exchange_rate: Number(order.data.exchangeRate),
	payment_method_id: order.data.paymentMethod,
	country: selectedRegion?.isoCode || '',
	chain_id: cryptoCurrency?.chainId || '',
	currency_destination:
	selectedWalletAddress || order.data.walletAddress,
	currency_source: order.data.fiatCurrency,
	};
	if (isCompleted) {
	trackEvent('RAMPS_TRANSACTION_COMPLETED', {
	...baseAnalyticsData,
	gas_fee: order.data.networkFees
	? Number(order.data.networkFees)
	: 0,
	processing_fee: order.data.partnerFees
	? Number(order.data.partnerFees)
	: 0,
	total_fee: Number(order.data.totalFeesFiat),
	});
	} else if (isFailed) {
	trackEvent('RAMPS_TRANSACTION_FAILED', {
	...baseAnalyticsData,
	gas_fee: order.data.networkFees
	? Number(order.data.networkFees)
	: 0,
	processing_fee: order.data.partnerFees
	? Number(order.data.partnerFees)
	: 0,
	total_fee: Number(order.data.totalFeesFiat),
	error_message: order.data.statusDescription || 'transaction_failed',
	});
	}
	}
	}
	}, [
	order,
	navigation,
	orderId,
	trackEvent,
	selectedWalletAddress,
	selectedRegion,
	]);

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: da6370b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/731fd52c-ee38-44a4-a492-b092db9f9d06

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud