Skip to content

fix: Terms of Use aligned with the new design cp-7.52.0 #17447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

fix: Terms of Use aligned with the new design cp-7.52.0 #17447

merged 5 commits into from
Jul 23, 2025
+85 −3

Conversation

@smgv
Copy link
Contributor

@smgv smgv commented Jul 22, 2025 •
edited
Loading

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to the Gets Started Screen
  2. Click on Get Started Button
  3. Will open the Terms of Use Bottom Sheet

Screenshots/Recordings

Before

#16705
#15782

After

Screen.Recording.2025-07-22.at.4.35.22.PM.mov
Screenshot 2025-07-22 at 4 36 01 PM Screenshot 2025-07-22 at 4 36 24 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@smgv smgv requested a review from chaitanyapotti July 22, 2025 11:08
@smgv smgv self-assigned this Jul 22, 2025
@smgv smgv requested a review from a team as a code owner July 22, 2025 11:08
@smgv smgv added area-onboarding needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E team-onboarding Onboarding team labels Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 92066f1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/733abbdc-6618-4810-afd8-9973fff499d8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.74%. Comparing base (5184987) to head (92066f1).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17447      +/-   ##
==========================================
+ Coverage   73.57%   73.74%   +0.17%     
==========================================
  Files        2845     2846       +1     
  Lines       63338    63675     +337     
  Branches    10328    10401      +73     
==========================================
+ Hits        46598    46958     +360     
+ Misses      13741    13690      -51     
- Partials     2999     3027      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e2b5623
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ff74da2c-9597-4150-9a6a-65f21979f8c8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Jul 23, 2025
@smgv smgv moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 23, 2025
@LeVinhGithub LeVinhGithub added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 23, 2025
@LeVinhGithub
Copy link
Contributor

LeVinhGithub commented Jul 23, 2025

lgtm

@chaitanyapotti chaitanyapotti changed the title fix: Terms of Use aligned with the new design fix: Terms of Use aligned with the new design cp-7.52.0 Jul 23, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hieu-w hieu-w enabled auto-merge July 23, 2025 16:08
@hieu-w hieu-w added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2025
@hieu-w hieu-w added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 54b9e63 Jul 23, 2025
56 of 58 checks passed
@hieu-w hieu-w deleted the fix/terms-of-use branch July 23, 2025 17:26
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jul 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 23, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 7, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

12 similar comments
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 13, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 3, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

Assignees

@smgv smgv

Labels

area-onboarding QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-onboarding Onboarding team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@smgv @codecov-commenter @LeVinhGithub @metamaskbot @chaitanyapotti @brianacnguyen @tommasini @hieu-w